tests: notification driver isn't properly cleaned up

Bug #1284549 reported by Isaku Yamahata
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Low
Isaku Yamahata

Bug Description

Some unit tests override notification driver, but doesn't clean it up properly.
So tests can be run against unintended notification driver resulting in error.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76139

Changed in neutron:
assignee: nobody → Isaku Yamahata (yamahata)
status: New → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Is bug 1281481 another manifest of this bug?

Revision history for this message
Isaku Yamahata (yamahata) wrote :

Maybe. Although they are related, I don't think the proposed patch fixes bug 1281481.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/76418

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/76139
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4434882bc41c87c52192ab3ad01d3448868603cc
Submitter: Jenkins
Branch: master

commit 4434882bc41c87c52192ab3ad01d3448868603cc
Author: Isaku Yamahata <email address hidden>
Date: Tue Feb 25 15:34:53 2014 +0900

    tests/unit: clean up notification driver

    Some tests doesn't cleanup notification driver. So some tests can
    run against unintended notification driver depending on execution order

    Change-Id: I7dbed47153be66684827b2693bbc995dddfb4c1b
    Related-Bug: #1281481
    Partial-Bug: #1284549

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/76418
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a98dc7680d4689f5ce5f602f9c5cb3bcc77de215
Submitter: Jenkins
Branch: master

commit a98dc7680d4689f5ce5f602f9c5cb3bcc77de215
Author: Isaku Yamahata <email address hidden>
Date: Wed Feb 26 11:36:56 2014 +0900

    tests/unit: refactor reading neutron.conf.test

    neutron.conf.test includes rpc_backend whose value is stashed.
    Thus it is required to reset when tearing down, otherwise the stale status
    will be used by succeeding tests causing random error.

    This patch refactors reading neutron.conf.test and resets the status of
    rpc_backend properly.

    Closes-Bug: #1281481
    Closes-Bug: #1284549
    Change-Id: I0fa5945b6adbb9945d353028ec88d00ccbf4e31a

Changed in neutron:
status: In Progress → Fix Committed
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Low
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers