ovs-agent test_fdb_add_flows test invalid

Bug #1284265 reported by Darragh O'Reilly
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Sridhar Gaddam

Bug Description

https://github.com/openstack/neutron/blob/14cb886809e5cccbf799a0dc2e5b99f31b1ab3be/neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py#L577

has:
mock.patch.object(self.agent.tun_br, 'setup_tunnel_port')

but setup_tunnel_port is an attribute of self.agent and not self.agent.tun_br.

tags: added: low-hanging-fruit ovs unittest
Changed in neutron:
assignee: nobody → Sridhar Gaddam (sridhargaddam)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83913

Changed in neutron:
milestone: none → juno-1
importance: Undecided → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/83913
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=aeea31b21245864888f4744c19a0fed2a9c6567e
Submitter: Jenkins
Branch: master

commit aeea31b21245864888f4744c19a0fed2a9c6567e
Author: sridhargaddam <email address hidden>
Date: Sat Mar 29 03:40:27 2014 +0530

    Invalid ovs-agent test case - test_fdb_add_flows

    setup_tunnel_port is an attribute of self.agent and not self.agent.tun_br.
    This patch fixes the testcase accordingly.

    Closes-Bug: #1284265
    Change-Id: I70582e477bb53de6482e32d5913c0864c5d910cc

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.