all plugins should call __init__ in db_base_plugin for db.configure

Bug #1282303 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Aaron Rosen

Bug Description

Currently each plugin calls db.configure() within the plugin's __init__ class or defines an initialize() method that's sole job is to call this method. Instead we should just call the super method of the db_base_plugin so that it calls this for us automatically.

Note: the only reason why I'm making this change is that I want to add something to the __init__() class of the db_base_plugin that's needed for the nova-event-callback blueprint and adding it in the base class of init looks to be the best place.

Aaron Rosen (arosen)
Changed in neutron:
assignee: nobody → Aaron Rosen (arosen)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74896

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/74896
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=326b85dd6154048b1671732d2d7df8deb8b99207
Submitter: Jenkins
Branch: master

commit 326b85dd6154048b1671732d2d7df8deb8b99207
Author: Aaron Rosen <email address hidden>
Date: Wed Feb 19 15:08:54 2014 -0800

    Plugins should call __init__ of db_base_plugin for db.configure

    Currently each plugin calls db.configure() within the plugin's __init__
    class or defines an initialize() method that's sole job is to call this
    method. Instead we should just call the super method of a plugin so that
    db.configure() is called for us out of the db_base_plugin class.

    Note: the only reason why I'm making this change is that I want to add
    something to the __init__() class of the db_base_plugin that's needed for
    the nova-event-callback blueprint and adding it in the base class of init
    looks to be the best place.

    Change-Id: Iec3c912735021ceb90f657108aad3a57460d66e7
    Closes-bug: #1282303

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.