test_openvswitch_plugin sometimes fail

[YAMAMOTO Takashi]

depending on the sequence of tests, test_openvswitch_plugin sometimes ends up to kick
unexpected code via impl_fake rpc backend.

an example of the failure:
http://logs.openstack.org/91/71791/5/check/gate-neutron-python27/2317e6a/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/74305

[Oleg Bondarev (obondarev)]

Can't find the error using the provided link

[Itsuro Oda (oda-g)]

Oleg,

Test is failed by 'sudo /usr/local/jenkins/slave_scripts/jenkins-sudo-grep.sh post'.

[Isaku Yamahata (yamahata)]

The patch fixes only ovs plugin test case.
Similar fix would be necessary for other test case which is subclass of NeutronDbPluginV2TestCase?

[YAMAMOTO Takashi (yamamoto)]

obondarev,

you need to read the log carefully find the error.
http://logs.openstack.org/91/71791/5/check/gate-neutron-python27/2317e6a/console.html.gz#_2014-02-14_07_39_59_698

the output is not verbose due to another bug.
https://bugs.launchpad.net/openstack-ci/+bug/1281353

[YAMAMOTO Takashi (yamamoto)]

yamahata,

probably.
ryu plugin test already has the similar mocking.
i haven't checked others.

[Mark McClain (markmcclain)]

Why don't we make the test clean-up the notifications vs adding a mock to cover up the issue.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/76418

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76139
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4434882bc41c87c52192ab3ad01d3448868603cc
Submitter: Jenkins
Branch: master

commit 4434882bc41c87c52192ab3ad01d3448868603cc
Author: Isaku Yamahata <email address hidden>
Date: Tue Feb 25 15:34:53 2014 +0900

    tests/unit: clean up notification driver

    Some tests doesn't cleanup notification driver. So some tests can
    run against unintended notification driver depending on execution order

    Change-Id: I7dbed47153be66684827b2693bbc995dddfb4c1b
    Related-Bug: #1281481
    Partial-Bug: #1284549

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/76418
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a98dc7680d4689f5ce5f602f9c5cb3bcc77de215
Submitter: Jenkins
Branch: master

commit a98dc7680d4689f5ce5f602f9c5cb3bcc77de215
Author: Isaku Yamahata <email address hidden>
Date: Wed Feb 26 11:36:56 2014 +0900

    tests/unit: refactor reading neutron.conf.test

    neutron.conf.test includes rpc_backend whose value is stashed.
    Thus it is required to reset when tearing down, otherwise the stale status
    will be used by succeeding tests causing random error.

    This patch refactors reading neutron.conf.test and resets the status of
    rpc_backend properly.

    Closes-Bug: #1281481
    Closes-Bug: #1284549
    Change-Id: I0fa5945b6adbb9945d353028ec88d00ccbf4e31a