excutils.save_and_reraise_exception should be used when reraising an exception

Bug #1279813 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki

Bug Description

excutils.save_and_reraise_exception should be used when reraising an exception, as described in openstack.common.excutils.

I don't see any issues due to this but it is better to be fixed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73293

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/73294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/73295

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/73293
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b3ec1cd6578a19413893a6b2ef276532c44c2a4f
Submitter: Jenkins
Branch: master

commit b3ec1cd6578a19413893a6b2ef276532c44c2a4f
Author: Akihiro Motoki <email address hidden>
Date: Wed Feb 12 23:18:36 2014 +0900

    Use save_and_reraise_exception when reraise exception

    This commit fixes neutron core and common codes.

    Partial-Bug: #1279813
    Change-Id: Id109924c7ff9b4f0d74c23665016a54bfd7dff77

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/73295
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6b13ee0c3b446b7fc4f440dd58c9226bf4abfdf8
Submitter: Jenkins
Branch: master

commit 6b13ee0c3b446b7fc4f440dd58c9226bf4abfdf8
Author: Akihiro Motoki <email address hidden>
Date: Thu Feb 13 02:51:45 2014 +0900

    Avoid using "raise" to reraise with modified exception

    The code changes the exception and reraises it.
    This commit changes the code to use the same way as
    excutils.save_and_reraise_exception does to ensure
    the exception context.

    This is the last patch of reraise clean up series.

    Closes-Bug: #1279813
    Change-Id: I8787dcbdc8321f75964de26e97cae395707aafc2

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/73294
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3c0025abf4581dc3561637e802de7bba1434d2b3
Submitter: Jenkins
Branch: master

commit 3c0025abf4581dc3561637e802de7bba1434d2b3
Author: Akihiro Motoki <email address hidden>
Date: Wed Feb 12 23:25:14 2014 +0900

    Use save_and_reraise_exception when reraise exception

    This fixes reraise in pluign codes.

    Closes-Bug: #1279813
    Change-Id: Iee174d94c0ce69eb01eb86eea1a903eceb7569d5

Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.