folsom_initial db migration does not create quotas table
Bug #1277379 reported by
Akihiro Motoki
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Medium
|
Ann Taraday |
Bug Description
When using the master branch (now Icehouse),
folsom_initial db migration does not create quotas table
for a plugin which had db quota support (quota-ext).
It is because neutron/
It affects OVS, Linuxbridge, ML2 and NVP plugins.
It causes potential db migration failure when the migration changes quotas table (like https:/
Changed in neutron: | |
assignee: | Akihiro Motoki (amotoki) → Henry Gessau (gessau) |
status: | New → In Progress |
Changed in neutron: | |
assignee: | Henry Gessau (gessau) → Akihiro Motoki (amotoki) |
Changed in neutron: | |
assignee: | Akihiro Motoki (amotoki) → Henry Gessau (gessau) |
Changed in neutron: | |
assignee: | Henry Gessau (gessau) → Ann Kamyshnikova (akamyshnikova) |
Changed in neutron: | |
milestone: | none → juno-2 |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | juno-2 → 2014.2 |
To post a comment you must log in.
I think there are several options to fix this:
(a) Remove db_driver config check from db/migration/ alembic_ migrations/ env.py alembic_ migrations/ env.py to the current path
(b) Change QUOTA_DB_DRIVER in db/migration/
I prefer to option (a).
The following is a discussion.
- For new deployment, either option works.
- For running system (including trunk chaser) with quota db driver: both works. quotas table already exists and future migrations related to quotas table works.
- For running system (including trunk chaser) with config quota driver:
-- option (a) future migraiton scripts related quotas table fails because there is no quotas table.
-- option (b) future migraiton scripts related quotas table may fails if future migration scripts do not take care of config options.
My question is whether we should consider config option in db migration scripts.
IMO it is better db migration scripts do not depend on config parameters, i.e., I prefer to option (a).