neutron-metadata-agent incorrectly passes keystone token to neutronclient

[Ihar Hrachyshka]

When instantiating a neutron client, the agent passes keystone token to object __init__ as auth_token= keyword argument, while neutronclient expects token=. This results in extensive interaction with keystone on cloud-init service startup because each request from an instance to metadata agent results in new token request.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/70178

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/70178
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3799efe792700e7736666c40cc42c265eee09230
Submitter: Jenkins
Branch: master

commit 3799efe792700e7736666c40cc42c265eee09230
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jan 30 13:42:29 2014 +0100

    Fix passing keystone token to neutronclient instance

    Neutron client expects token to be passed as token= argument, while
    neutron-metadata-agent passes auth_token= instead. This effectively makes the
    client to authenticate against keystone each time it's instantiated. In
    neutron-metadata-agent case, it means 'each time a client sends a metadata
    request.'

    The issue results in high cpu utilization on keystone side when simultaneously
    invoking multiple nova instances with cloud-init.

    Change-Id: I2a31f9c0c3cfa915975ecc53d71168a3895528d8
    Closes-Bug: 1274487

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/72754

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72754
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=15a912b1ca3c24ba8851b8b77d6de8027e120d78
Submitter: Jenkins
Branch: stable/havana

commit 15a912b1ca3c24ba8851b8b77d6de8027e120d78
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jan 30 13:42:29 2014 +0100

    Fix passing keystone token to neutronclient instance

    Neutron client expects token to be passed as token= argument, while
    neutron-metadata-agent passes auth_token= instead. This effectively makes the
    client to authenticate against keystone each time it's instantiated. In
    neutron-metadata-agent case, it means 'each time a client sends a metadata
    request.'

    The issue results in high cpu utilization on keystone side when simultaneously
    invoking multiple nova instances with cloud-init.

    Change-Id: I2a31f9c0c3cfa915975ecc53d71168a3895528d8
    Closes-Bug: 1274487
    (cherry picked from commit 3799efe792700e7736666c40cc42c265eee09230)