ML2 unit test coverage - db

[Amir Sadoughi]

From tox -e cover neutron.tests.unit.ml2; coverage report -m:

neutron/plugins/ml2/db 68 13 2 0 81% 88-93, 125-135

With TOT neutron code:

neutron/plugins/ml2/db 149 27 0 24 3 79%

[Armando Migliaccio (armando-migliaccio)]

Hi Manish,

Are you actively working on this? As part of effort for https://review.openstack.org/#/c/102101/

I was planning of adding UT coverage for the DVR side of things. I don't mind going over the other bits though depending what you've been up to.

Many thanks,
Armando

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/104731

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/104731
Reason: Superseded by https://review.openstack.org/#/c/82945/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104731
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0b30651678e1e2e574553272c0f9ab69418efe96
Submitter: Jenkins
Branch: master

commit 0b30651678e1e2e574553272c0f9ab69418efe96
Author: armando-migliaccio <email address hidden>
Date: Thu Jul 3 17:00:44 2014 -0700

    Make ML2 ensure_dvr_port_binding more robust

    There is a remote chance that this operation may
    be prone to DB integrity errors, in case the binding
    is attempted on the same port twice.

    Ideally getter methods should not create, but this
    is a common Neutron (anti)-pattern that would be
    difficult to eradicate (at least in a single patch);
    so for now let's make this code more defensive.

    Related-bug: #1269131
    Related-bug: #1335226

    Change-Id: Ie6c57fd46f0752839814dbac5b14fae2364f973d

[Romil Gupta (romilg)]

Hi Manish,

I would like to write the UT's for ML2/db.py. Shall I assign this bug to myself and post the patch set if you have not started yet ?

Thanks,
Romil

[Manish Godara (manishatyhoo)]

@armando-migliaccio: somehow missed the comments on this :( Sorry about that. romilg said he can work on it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/130941

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/130941
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e3383f9ac573863c49bf02ff65ea1f8ac1f2b5ee
Submitter: Jenkins
Branch: master

commit e3383f9ac573863c49bf02ff65ea1f8ac1f2b5ee
Author: Romil Gupta <email address hidden>
Date: Sat Oct 25 04:04:13 2014 -0700

    Improve unit test coverage for Ml2 db.py

    From coverage report:

    Module statements missing excluded branches partial coverage
    neutron/plugins/ml2/db 149 9 0 24 3 90%

    Partial-Bug: #1269131
    Change-Id: I5ef2af33d3a723fadfe618064094ea22241b7da1

[Romil Gupta (romilg)]

Sorry...it's not complete. It's partially fixed.