Calls to get_fixed_ip are not implemented when using neutron

[Brent Eagles]

The get_fixed_ip() the nova.network.neutronv2.api module is not implemented.

[Gary Kotton (garyk)]

Please see the comment here:

    def get_fixed_ip(self, context, id):
        """Return a fixed ip."""
        # NOTE(vish): This is no longer used but can't be removed until
        # we major version the network_rpcapi to 2.0.
        fixed = self.db.fixed_ip_get(context, id)
        return jsonutils.to_primitive(fixed)

Is this still relevant?

[Brent Eagles (beagles)]

Good question. Considering the RPC API only used internally and is no longer used, I'd say no. Ideally, we would add a comment to neutronv2/api.py. Perhaps it would be best to make a "mondo" comment at the top of the file that lists the deliberately unimplemented methods and why.

[Brent Eagles (beagles)]

I was incorrect in my last statement. The comment indicated above exists in code that is not used by the nova-network API implementation and is implemented and still in use. This should be implemented.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/97101

[Chris Behrens (cbehrens)]

I do not see any place where this is used for neutron. The only reference to this that I can find is:

1219 if utils.is_neutron():
1220 fixed_vm_uuid = floating_ip['instance']['uuid']
1221 if fixed_vm_uuid is not None:
1222 ec2_id = ec2utils.id_to_ec2_inst_id(fixed_vm_uuid)
1223 else:
1224 fixed_id = floating_ip['fixed_ip_id']
1225 fixed = self.network_api.get_fixed_ip(context, fixed_id)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^
1226 if fixed['instance_uuid'] is not None:
1227 ec2_id = ec2utils.id_to_ec2_inst_id(fixed['instance_uui

[Eugene Nikanorov (enikanorov)]

Yep, exactly, so I'm confused about what is expected and how to test it.

[Marios Andreou (marios-b)]

so grep doesn't show me any invocation of 'get_fixed_ip' on the neutron side - is there in fact anything to be done there?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/97101
Reason: Patch is stalled waiting for the author, looks like this has been abandoned. Feel free to restore.

[Eugene Nikanorov (enikanorov)]

Invalid for neutron.
Apparently get_fixed_ip() is not needed in nova as well.

[Markus Zoeller (markus_z) (mzoeller)]

Raises a NotImplementedError in the mean time: https://github.com/openstack/nova/blob/1335abb5da5acdbe3596f0d6443efc65ea075b90/nova/network/neutronv2/api.py#L1317