Don't require passing in port_security=False if security groups

Bug #1267249 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Aaron Rosen

Bug Description

If creating a port on a network that is marked port_security_enabled=False and one passes in a security_group in the port_create request previously an error was raised saying they needed to also pass in port_security_enabled=False. Instead it would be better if we didn't require them to pass port_security_enabled=True explicitly and just default it to true if they pass in a security_group.

Aaron Rosen (arosen)
Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Aaron Rosen (arosen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/65544

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/65544
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a5ccc2358dcc2cee5bc8db6a4448f58bae40b67b
Submitter: Jenkins
Branch: master

commit a5ccc2358dcc2cee5bc8db6a4448f58bae40b67b
Author: Aaron Rosen <email address hidden>
Date: Wed Jan 8 13:10:54 2014 -0800

    Don't require passing in port_security=False if security_groups present

    If creating a port on a network that is marked as port_security_enabled=False
    and one passes in a security_group in the port_create request previously an
    error was raised saying they needed to also pass in
    port_security_enabled=False. This patch removes that requirement and instead
    sets port_security_enabled=True internally if a port has an ip_address and a
    security_group is passed in. This is more convient and does not break
    backwards compatibility.

    Closes-bug: #1267249
    Change-Id: Ifb5a5511f016a5d8c5b5075c9fdc27279cdd9bb5

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.