ValueError should use '%' instead of ','

Bug #1264210 reported by Haojie Jia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
yalei wang

Bug Description

The method _load_service_plugins() in /neutron/neutron/managers.py raise ValueError exception as follows:

if plugin_inst.get_plugin_type() in self.service_plugins:
                raise ValueError(_("Multiple plugins for service "
                                   "%s were configured"),
                                 plugin_inst.get_plugin_type())

ValueError do not support using ',' to connect log and variables,
we should use '%' instead, so it should be modified as:

if plugin_inst.get_plugin_type() in self.service_plugins:
                raise ValueError(_("Multiple plugins for service "
                                   "%s were configured") %
                                 plugin_inst.get_plugin_type())

Haojie Jia (jiahaojie)
Changed in neutron:
assignee: nobody → Haojie Jia (jiahaojie)
ZhiQiang Fan (aji-zqfan)
Changed in neutron:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64101

Changed in neutron:
status: Confirmed → In Progress
Changed in neutron:
importance: Undecided → Medium
wanghong (w-wanghong)
Changed in neutron:
assignee: Haojie Jia (jiahaojie) → wanghong (w-wanghong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/66490

Changed in neutron:
assignee: wanghong (w-wanghong) → Salvatore Orlando (salvatore-orlando)
Changed in neutron:
assignee: Salvatore Orlando (salvatore-orlando) → wanghong (w-wanghong)
wanghong (w-wanghong)
Changed in neutron:
assignee: wanghong (w-wanghong) → nobody
yalei wang (yalei-wang)
Changed in neutron:
assignee: nobody → yalei wang (yalei-wang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/100431

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/100431
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=61ac9c379f0acb43cd4bbcd9bd04cd9f53d315ca
Submitter: Jenkins
Branch: master

commit 61ac9c379f0acb43cd4bbcd9bd04cd9f53d315ca
Author: Yalei Wang <email address hidden>
Date: Tue Jun 17 10:56:46 2014 +0800

    ValueError should use '%' instead of ','

    The method _load_service_plugins() in /neutron/neutron/managers.py
     throw a ValueError using ',' to connect log and variables.
    ValueError do not support using ',' to connect log and variables,
    we should use '%' instead of ','

    Change-Id: Ic9b3756ac2bc36ddc689a66c078e205e0674f513
    Closes-Bug:#1264210

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.