| 2013-12-10 18:34:54 |
Lance Bragstad |
description |
In the current ML2 Manager, we are using sys.exit(1) if the network_type isn't found in self.drivers:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L70
Here we should probably throw an exception. When running unit test, if we hit this condition the unit tests will exit as well.
We should also be mindful of using the reserved keyword 'type' and rename type in this case to something else:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L49 |
Some things need cleanup in the ML2Manager.
1.) In the current ML2 Manager, we are using sys.exit(1) if the network_type isn't found in self.drivers:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L70
Here we should probably throw an exception. When running unit test, if we hit this condition the unit tests will exit as well.
2.) We should also be mindful of using the reserved keyword 'type' and rename type in this case to something else:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L49 |
|
