Add appropriate options for all command executing run_vsctl

[Xiang Hui]

Hi team,

xianghui@xianghui:~$ cat /etc/issue
Ubuntu 13.10 \n \l
xianghui@xianghui:~$ uname -a
Linux xianghui 3.11.0-18-generic #32-Ubuntu SMP Tue Feb 18 21:11:14 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
xianghui@xianghui:~$ sudo ovs-vsctl -V
ovs-vsctl (Open vSwitch) 1.10.2

I am encountering the following error when turning "integration_bridge" from "br-int" into "br-vlan" in /etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini and then restart service neutron-openvswitch-agent.

This error should be raised to stop the agent to remind operators what happened other than flooded in the log.

2013-11-27 21:54:17.517 28492 INFO neutron.plugins.openvswitch.agent.ovs_neutron_agent [-] NT-BCFFFD9 Mapping physical network physnet1 to bridge br-eth1
2013-11-27 21:54:17.754 28492 ERROR neutron.agent.linux.ovs_lib [-] NT-6945F00 Unable to execute ['ovs-vsctl', '--timeout=2', '--', '--if-exists', 'del-port', 'br-vlan', 'int-br-eth1']. Exception: NT-FDA3026
Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=2', '--', '--if-exists', 'del-port', 'br-vlan', 'int-br-eth1']
Exit code: 1
Stdout: ''
Stderr: 'ovs-vsctl: bridge br-vlan does not have a port int-br-eth1\n'
2013-11-27 21:54:18.379 28492 ERROR neutron.agent.linux.ovs_lib [-] NT-6945F00 Unable to execute ['ovs-vsctl', '--timeout=2', '--', '--may-exist', 'add-port', 'br-vlan', <neutron.agent.linux.ip_lib.IPDevice object at 0x292dfd0>]. Exception: NT-FDA3026
Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=2', '--', '--may-exist', 'add-port', 'br-vlan', 'int-br-eth1']
Exit code: 1
Stdout: ''
Stderr: 'ovs-vsctl: "--may-exist add-port br-vlan int-br-eth1" but int-br-eth1 is actually attached to bridge br-int\n'
2013-11-27 21:54:19.130 28628 INFO neutron.common.config [-] NT-21CCD27 Logging enabled!
2013-11-27 21:54:19.184 28628 INFO neutron.openstack.common.rpc.impl_qpid [-] NT-1A047FB Connected to AMQP server on localhost:5672
2013-11-27 21:54:19.220 28628 INFO neutron.openstack.common.rpc.impl_qpid [-] NT-1A047FB Connected to AMQP server on localhost:5672
2013-11-27 21:54:19.451 28628 INFO neutron.plugins.openvswitch.agent.ovs_neutron_agent [-] NT-BCFFFD9 Mapping physical network physnet1 to bridge br-eth1
2013-11-27 21:54:19.689 28628 ERROR neutron.agent.linux.ovs_lib [-] NT-6945F00 Unable to execute ['ovs-vsctl', '--timeout=2', '--', '--if-exists', 'del-port', 'br-vlan', 'int-br-eth1']. Exception: NT-FDA3026
Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=2', '--', '--if-exists', 'del-port', 'br-vlan', 'int-br-eth1']
Exit code: 1
Stdout: ''
Stderr: 'ovs-vsctl: bridge br-vlan does not have a port int-br-eth1\n'
2013-11-27 21:54:20.106 28628 ERROR neutron.agent.linux.ovs_lib [-] NT-6945F00 Unable to execute ['ovs-vsctl', '--timeout=2', '--', '--may-exist', 'add-port', 'br-vlan', <neutron.agent.linux.ip_lib.IPDevice object at 0x2645fd0>]. Exception: NT-FDA3026
Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=2', '--', '--may-exist', 'add-port', 'br-vlan', 'int-br-eth1']
Exit code: 1
Stdout: ''
Stderr: 'ovs-vsctl: "--may-exist add-port br-vlan int-br-eth1" but int-br-eth1 is actually attached to bridge br-int\n'
2013-11-27 21:54:20.947 28628 INFO neutron.plugins.openvswitch.agent.ovs_neutron_agent [-] NT-C66E965 Agent initialized successfully, now running...
2013-11-27 21:54:20.947 28628 INFO neutron.plugins.openvswitch.agent.ovs_neutron_agent [-] NT-CDF3B53 Agent out of sync with plugin!

All commands executing run_vsctl should appropriately raise the RuntimeError when do a setting operation and avoid raising the RuntimeError when do a getting operation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58954

[Armando Migliaccio (armando-migliaccio)]

This bug is > 172 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]