need to ignore swap files from getting into repository

Bug #1255876 reported by Sushil Kumar
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Invalid
Undecided
Unassigned
Glance Client
Fix Released
Undecided
Zhenguo Niu
Heat Templates
Invalid
Undecided
Unassigned
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Sushil Kumar
Sahara
Invalid
Undecided
Unassigned
neutron
Fix Released
Low
Zhenguo Niu
oslo-incubator
Won't Fix
Low
Unassigned
python-ceilometerclient
Fix Released
Undecided
Julien Danjou
python-cinderclient
Fix Released
Undecided
Zhenguo Niu
python-keystoneclient
Fix Released
Low
Zhenguo Niu
python-neutronclient
Fix Released
Low
Zhenguo Niu
python-novaclient
Fix Released
Low
Zhenguo Niu
python-swiftclient
Fix Released
Undecided
Zhenguo Niu

Bug Description

need to ignore swap files from getting into repository
currently the implemented ignore in .gitignore is *.swp
however vim goes beyond to generate these so to improve it could be done *.sw?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58948

Changed in horizon:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/58948
Committed: http://github.com/openstack/horizon/commit/5117c74d526e4f98f3051e2b1097b082766e92b5
Submitter: Jenkins
Branch: master

commit 5117c74d526e4f98f3051e2b1097b082766e92b5
Author: Sushil Kumar <email address hidden>
Date: Thu Nov 28 08:53:19 2013 +0000

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: I91c799acfe186791061cd91414f606fd7cf08fb7
    Closes-Bug: #1255876

Changed in horizon:
status: In Progress → Fix Committed
Changed in neutron:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in keystone:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in cinder:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in glance:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-novaclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in ceilometer:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in heat-templates:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in swift:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in savanna:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in trove:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-keystoneclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-cinderclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-glanceclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-neutronclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-swiftclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in python-ceilometerclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59020

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59021

Changed in python-ceilometerclient:
status: New → In Progress
Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59022

Changed in python-glanceclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59023

Changed in python-keystoneclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59024

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59026

Changed in python-neutronclient:
status: New → In Progress
Changed in python-heatclient:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59028

Changed in python-novaclient:
status: New → In Progress
Changed in python-swiftclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-swiftclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59031

Changed in python-heatclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59032

no longer affects: glance
no longer affects: keystone
no longer affects: cinder
no longer affects: heat
no longer affects: trove
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59045

Changed in neutron:
status: New → In Progress
no longer affects: swift
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59052

Changed in oslo:
assignee: nobody → Zhenguo Niu (niu-zglinux)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59089

Changed in python-ceilometerclient:
assignee: Zhenguo Niu (niu-zglinux) → Julien Danjou (jdanjou)
Changed in neutron:
importance: Undecided → Low
Changed in python-neutronclient:
importance: Undecided → Low
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Just as with editor-specific settings in the source files, I think we should leave editor-specific ignore files up to the developer to configure locally.

Changed in oslo:
importance: Undecided → Low
Revision history for this message
Sergey Lukjanov (slukjanov) wrote :

It could be easily solved by configuring global git ignore. There are tons of editors, IDEs and we should not add project/swap files of all of them to the .gitignore.

Changed in savanna:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-swiftclient (master)

Reviewed: https://review.openstack.org/59031
Committed: http://github.com/openstack/python-swiftclient/commit/0ef054585a93f80ba4bc72f953f832372e65db60
Submitter: Jenkins
Branch: master

commit 0ef054585a93f80ba4bc72f953f832372e65db60
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 22:37:58 2013 +0800

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: I48846345de6838735d2d2e46328698f6a526f397
    Closes-Bug: #1255876

Changed in python-swiftclient:
status: In Progress → Fix Committed
Revision history for this message
Zhenguo Niu (niu-zglinux) wrote :

but we already have *.swp in .gitignore, should we just remove it?

Revision history for this message
Sushil Kumar (sushil-kumar2) wrote :

Sergey Lukjanov not all of them could be inclued, but the most commons should be included, just to help everyone.

Julien Danjou (jdanjou)
Changed in ceilometer:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/59045
Committed: http://github.com/openstack/neutron/commit/39f44068a722c71029265d34531bba11947b3eac
Submitter: Jenkins
Branch: master

commit 39f44068a722c71029265d34531bba11947b3eac
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 23:12:00 2013 +0800

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignores are *.swp and *.swo
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: Ie1b458d2b862e6cf2552ae5be6c6178b72e960ab
    Closes-Bug: #1255876

Changed in neutron:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/59028
Committed: http://github.com/openstack/python-novaclient/commit/beb30f714ec871b6ef7c0506a7186ce739c21bd1
Submitter: Jenkins
Branch: master

commit beb30f714ec871b6ef7c0506a7186ce739c21bd1
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 22:34:12 2013 +0800

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: Ic3e09f8cf0be35c98d89d862d40121a09c7b2498
    Closes-Bug: #1255876

Changed in python-novaclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/59026
Committed: http://github.com/openstack/python-neutronclient/commit/c3e01a7e4604948122355dbf9b9317160bc22eab
Submitter: Jenkins
Branch: master

commit c3e01a7e4604948122355dbf9b9317160bc22eab
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 22:27:06 2013 +0800

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: I9384015efdd1bc2a9bbfe6f25552cd909b155998
    Closes-Bug: #1255876

Changed in python-neutronclient:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Changed in python-novaclient:
importance: Undecided → Low
Changed in python-heatclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/59023
Committed: http://github.com/openstack/python-glanceclient/commit/cd7f2cbd79df54ea41d9a075d904efc82bdcb440
Submitter: Jenkins
Branch: master

commit cd7f2cbd79df54ea41d9a075d904efc82bdcb440
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 22:18:19 2013 +0800

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: I1f3ee52050ac6812c34357ad786fd8210f4238f2
    Closes-Bug: #1255876

Changed in python-glanceclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/59022
Committed: http://github.com/openstack/python-cinderclient/commit/8fc5ae480eafffc7e1bea046ad9b8e06350b008e
Submitter: Jenkins
Branch: master

commit 8fc5ae480eafffc7e1bea046ad9b8e06350b008e
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 22:13:47 2013 +0800

    Ignore swap files generated during file edting by vim

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with .*.sw?

    Change-Id: I11965d5fb22aeae622dad8bb29cf1f0533ed439a
    Closes-Bug: #1255876

Changed in heat-templates:
assignee: Zhenguo Niu (niu-zglinux) → nobody
Changed in oslo:
assignee: Zhenguo Niu (niu-zglinux) → nobody
Changed in savanna:
assignee: Zhenguo Niu (niu-zglinux) → nobody
Changed in ceilometer:
assignee: Zhenguo Niu (niu-zglinux) → nobody
Changed in python-heatclient:
assignee: Zhenguo Niu (niu-zglinux) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/59024
Committed: http://github.com/openstack/python-keystoneclient/commit/6e029425eb268730e638bfa142fbd1c2fbef78e2
Submitter: Jenkins
Branch: master

commit 6e029425eb268730e638bfa142fbd1c2fbef78e2
Author: Zhenguo Niu <email address hidden>
Date: Thu Nov 28 22:23:29 2013 +0800

    Updates .gitignore

    To ignore swap files from getting into repository
    currently the implemented ignore is *.swp
    however vim adds more swap files if these files exists,
    so improving this with *.sw?

    Change-Id: Iff581457cabe936b8b285142caff92fcc849f04a
    Closes-Bug: #1255876

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ceilometerclient (master)

Reviewed: https://review.openstack.org/59089
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=77e7a751383b7a2aa1a74b20a005c701e62359c1
Submitter: Jenkins
Branch: master

commit 77e7a751383b7a2aa1a74b20a005c701e62359c1
Author: Julien Danjou <email address hidden>
Date: Thu Nov 28 19:39:06 2013 +0100

    Update .gitignore

    Remove files we don't generate in the sources.

    Closes-Bug: #1255876
    Change-Id: I27f09156876f9a86071b29835688c9860e7d5107

Changed in python-ceilometerclient:
status: In Progress → Fix Committed
Changed in oslo:
status: In Progress → Won't Fix
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.4.2
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Revision history for this message
melanie witt (melwitt) wrote :

novaclient 2.16.0 released on 2/26/2014

Changed in python-novaclient:
status: Fix Committed → Fix Released
no longer affects: python-heatclient
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-1 → 2014.1
Zane Bitter (zaneb)
Changed in heat-templates:
status: New → Invalid
Louis Taylor (kragniz)
Changed in python-glanceclient:
status: Fix Committed → Fix Released
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 2.3.0-2.3.4
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
Changed in python-ceilometerclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
Changed in python-swiftclient:
milestone: none → 2.5.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers