Comment 7 for bug 1255338

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/88057
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=03eed8cd34cd4fb043c11fc99f6bb0b4fbd5728d
Submitter: Jenkins
Branch: stable/havana

commit 03eed8cd34cd4fb043c11fc99f6bb0b4fbd5728d
Author: marios <email address hidden>
Date: Fri Nov 29 18:23:54 2013 +0200

    Validate CIDR given as ip-prefix in security-group-rule-create

    There was no validation for the provided ip prefix. This just adds
    a simple parse using netaddr and explodes with appropriate message.
    Also makes sure ip prefix _is_ cidr (192.168.1.1-->192.168.1.1/32).

    Validation occurs at the attribute level (API model) as well as at
    the db level, where the ethertype is validated against the ip_prefix
    address type.

    Unit test cases added - bad prefix, unmasked prefix and incorrect
    ethertype. Also adds attribute test cases for the added
    convert_ip_prefix_to_cidr method

    Closes-Bug: 1255338

    Conflicts:
     neutron/tests/unit/test_security_groups_rpc.py
     neutron/tests/unit/test_extension_security_group.py

    Change-Id: I71fb8c887963a122a5bd8cfdda800026c1cd3954
    (cherry picked from commit 65aa92b0348b7ab8413f359b00825610cdf66607)