uncaught portnotfound exception on get_dhcp_port

[Armando Migliaccio]

While working on fix for bug #1251874 I have noticed this stacktrace in the log:

2013-11-18 17:20:46.237 1021 ERROR neutron.openstack.common.rpc.amqp [-] Exception during message handling
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp Traceback (most recent call last):
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/openstack/common/rpc/amqp.py", line 438, in _process_data
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp **args)
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/common/rpc.py", line 44, in dispatch
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp neutron_ctxt, version, method, namespace, **kwargs)
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/openstack/common/rpc/dispatcher.py", line 172, in dispatch
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp result = getattr(proxyobj, method)(ctxt, **kwargs)
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/db/dhcp_rpc_base.py", line 139, in get_dhcp_port
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp dict(port=port))
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/plugins/ml2/plugin.py", line 588, in update_port
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp original_port = super(Ml2Plugin, self).get_port(context, id)
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/db/db_base_plugin_v2.py", line 1454, in get_port
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp port = self._get_port(context, id)
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/new/neutron/neutron/db/db_base_plugin_v2.py", line 266, in _get_port
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp raise q_exc.PortNotFound(port_id=id)
2013-11-18 17:20:46.237 1021 TRACE neutron.openstack.common.rpc.amqp PortNotFound: Port d68c27dd-210b-4b10-9c41-40ba01aa0fd3 could not be found

This is because the try-except looks for exc.NoResultFound and this is obviously a mistake.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57043

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57043
Committed: http://github.com/openstack/neutron/commit/cbe91fda7b416717a23cf7b29adf8201a8c14822
Submitter: Jenkins
Branch: master

commit cbe91fda7b416717a23cf7b29adf8201a8c14822
Author: armando-migliaccio <email address hidden>
Date: Mon Nov 18 12:13:36 2013 -0800

    Catch PortNotFound exception during get_dhcp_port

    Close-bug: 1252437

    Change-Id: I3a7954b869b4f5b909c806f8e47180e1ba6ba374

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/60569

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60569
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4bfc5109c99b44b7b8470c5612fc541c09d3c4aa
Submitter: Jenkins
Branch: stable/havana

commit 4bfc5109c99b44b7b8470c5612fc541c09d3c4aa
Author: armando-migliaccio <email address hidden>
Date: Mon Nov 18 12:13:36 2013 -0800

    Catch PortNotFound exception during get_dhcp_port

    Close-bug: 1252437

    Change-Id: I3a7954b869b4f5b909c806f8e47180e1ba6ba374
    (cherry picked from commit cbe91fda7b416717a23cf7b29adf8201a8c14822)