[neutron bandwidth metering] When I delete a label, router's tenant_id disappeared.

Bug #1249188 reported by leegayeon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Oleg Bondarev
Havana
Fix Released
High
Sylvain Afchain

Bug Description

[neutron bandwidth metering]

I delete a label using neutronclient CLI (neutron meter-label-delete).
Then router's tenant_id is omitted.
I don' t know why.
it's a bug maybe

Changed in neutron:
assignee: nobody → Oleg Bondarev (obondarev)
Revision history for this message
Oleg Bondarev (obondarev) wrote :

Not able to reproduce, can you please add more info for the bug: complete set of commands executed, where router's tenant_id was expected to be, etc.

Changed in neutron:
status: New → Incomplete
Revision history for this message
leegayeon (leegy) wrote :
Download full text (4.4 KiB)

Sure :) This is my commands.
====================================================================================================

root@OPNSTHAVDEV:~# neutron meter-label-list
+--------------------------------------+-----------------+-------------+
| id | name | description |
+--------------------------------------+-----------------+-------------+
| 06e314db-7cb6-498a-8d85-c7a7ade31e1f | Label-Out-Pub | |
| 66b4903c-f435-4103-870d-41928d42355d | Label04-Out-Pub | |
| 8083f44e-d3fe-4ee3-8be3-b30b1e193907 | Kim_Out_Pub | |
| 8d7fa11b-a9ab-4aad-9ca3-529fd1ca67a7 | Label04-In-Pub | |
| e7c6c4b6-0407-4752-8ce9-8065470d5b73 | Kim_In_Pub | |
| f2274972-dba6-40a2-8ebe-063b794048e6 | Label-In-Pub | |
+--------------------------------------+-----------------+-------------+

root@OPNSTHAVDEV:~# neutron router-list
+--------------------------------------+----------+-----------------------------------------------------------------------------+
| id | name | external_gateway_info |
+--------------------------------------+----------+-----------------------------------------------------------------------------+
| 6a72ef5b-3cc5-40a2-b795-0d2aae9b6b04 | Router | {"network_id": "4de355e3-ed28-47b4-b851-6a155c152925", "enable_snat": true} |
| 94431a6f-c9df-44b4-a70f-6e58fd589889 | Router01 | {"network_id": "4de355e3-ed28-47b4-b851-6a155c152925", "enable_snat": true} |
+--------------------------------------+----------+-----------------------------------------------------------------------------+

root@OPNSTHAVDEV:~# neutron router-show 94431a6f-c9df-44b4-a70f-6e58fd589889
+-----------------------+-----------------------------------------------------------------------------+
| Field | Value |
+-----------------------+-----------------------------------------------------------------------------+
| admin_state_up | True |
| external_gateway_info | {"network_id": "4de355e3-ed28-47b4-b851-6a155c152925", "enable_snat": true} |
| id | 94431a6f-c9df-44b4-a70f-6e58fd589889 |
| name | Router01 |
| routes | |
| status | ACTIVE |
| tenant_id | dcd8d6602a3b4f3cab35e68b4acdba19 |
+-----------------------+-----------------------------------------------------------------------------+

root@OPNSTHAVDEV:~#
root@OPNSTHAVDEV:~# neutron meter-label-delete 8083f44e-d3fe-4ee3-8be3-b30b1e193907
Deleted metering_label: 8083f44e-d3fe-4ee3-8be3-b30b1e193907

root@OPNSTHAVDEV:~#
root@OPNSTHAVDEV:~# neutron router-show 94431a6f-c9df-44b4-a70f-...

Read more...

leegayeon (leegy)
description: updated
summary: [neutron bandwidth metering] When I delete a label, router's tenant_id
- is disappeared.
+ disappeared.
Revision history for this message
Oleg Bondarev (obondarev) wrote :

Thanks, now able to reproduce, working on the fix

Changed in neutron:
status: Incomplete → Confirmed
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/56041

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Oleg Bondarev (obondarev) wrote :

BTW good catch! Thanks for reporting!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/56041
Committed: http://github.com/openstack/neutron/commit/d1220a3c22fccc1d86eaafeebe7ef9c074d4fcb9
Submitter: Jenkins
Branch: master

commit d1220a3c22fccc1d86eaafeebe7ef9c074d4fcb9
Author: Oleg Bondarev <email address hidden>
Date: Tue Nov 12 19:05:26 2013 +0400

    Fix MeteringLabel model to not clear router's tenant id on deletion

    foreign_keys parameter of orm.relationship should point to local columns.
    Currently for MeteringLabel it points to Router.tenant_id column which causes
    routers tenant_id clearing on label deletion.

    Closes-Bug: #1249188
    Change-Id: Iccc0daf4f6edd537fd7f9e4b2fc4be094543ca5d

Changed in neutron:
status: In Progress → Fix Committed
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/60477

Changed in neutron:
status: Fix Committed → In Progress
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
leegayeon (leegy)
Changed in neutron:
status: Fix Released → Fix Committed
Alan Pevec (apevec)
tags: removed: havana-backport-potential
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.