[neutron bandwidth metering] When I delete a label, router's tenant_id disappeared.

[leegayeon]

[neutron bandwidth metering]

I delete a label using neutronclient CLI (neutron meter-label-delete).
Then router's tenant_id is omitted.
I don' t know why.
it's a bug maybe

[Oleg Bondarev (obondarev)]

Not able to reproduce, can you please add more info for the bug: complete set of commands executed, where router's tenant_id was expected to be, etc.

[leegayeon (leegy)]

Sure :) This is my commands.
====================================================================================================

root@OPNSTHAVDEV:~# neutron meter-label-list
+--------------------------------------+-----------------+-------------+
| id | name | description |
+--------------------------------------+-----------------+-------------+
| 06e314db-7cb6-498a-8d85-c7a7ade31e1f | Label-Out-Pub | |
| 66b4903c-f435-4103-870d-41928d42355d | Label04-Out-Pub | |
| 8083f44e-d3fe-4ee3-8be3-b30b1e193907 | Kim_Out_Pub | |
| 8d7fa11b-a9ab-4aad-9ca3-529fd1ca67a7 | Label04-In-Pub | |
| e7c6c4b6-0407-4752-8ce9-8065470d5b73 | Kim_In_Pub | |
| f2274972-dba6-40a2-8ebe-063b794048e6 | Label-In-Pub | |
+--------------------------------------+-----------------+-------------+

root@OPNSTHAVDEV:~# neutron router-list
+--------------------------------------+----------+-----------------------------------------------------------------------------+
| id | name | external_gateway_info |
+--------------------------------------+----------+-----------------------------------------------------------------------------+
| 6a72ef5b-3cc5-40a2-b795-0d2aae9b6b04 | Router | {"network_id": "4de355e3-ed28-47b4-b851-6a155c152925", "enable_snat": true} |
| 94431a6f-c9df-44b4-a70f-6e58fd589889 | Router01 | {"network_id": "4de355e3-ed28-47b4-b851-6a155c152925", "enable_snat": true} |
+--------------------------------------+----------+-----------------------------------------------------------------------------+

root@OPNSTHAVDEV:~# neutron router-show 94431a6f-c9df-44b4-a70f-6e58fd589889
+-----------------------+-----------------------------------------------------------------------------+
| Field | Value |
+-----------------------+-----------------------------------------------------------------------------+
| admin_state_up | True |
| external_gateway_info | {"network_id": "4de355e3-ed28-47b4-b851-6a155c152925", "enable_snat": true} |
| id | 94431a6f-c9df-44b4-a70f-6e58fd589889 |
| name | Router01 |
| routes | |
| status | ACTIVE |
| tenant_id | dcd8d6602a3b4f3cab35e68b4acdba19 |
+-----------------------+-----------------------------------------------------------------------------+

root@OPNSTHAVDEV:~#
root@OPNSTHAVDEV:~# neutron meter-label-delete 8083f44e-d3fe-4ee3-8be3-b30b1e193907
Deleted metering_label: 8083f44e-d3fe-4ee3-8be3-b30b1e193907

root@OPNSTHAVDEV:~#
root@OPNSTHAVDEV:~# neutron router-show 94431a6f-c9df-44b4-a70f-...

[Oleg Bondarev (obondarev)]

Thanks, now able to reproduce, working on the fix

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/56041

[Oleg Bondarev (obondarev)]

BTW good catch! Thanks for reporting!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/56041
Committed: http://github.com/openstack/neutron/commit/d1220a3c22fccc1d86eaafeebe7ef9c074d4fcb9
Submitter: Jenkins
Branch: master

commit d1220a3c22fccc1d86eaafeebe7ef9c074d4fcb9
Author: Oleg Bondarev <email address hidden>
Date: Tue Nov 12 19:05:26 2013 +0400

    Fix MeteringLabel model to not clear router's tenant id on deletion

    foreign_keys parameter of orm.relationship should point to local columns.
    Currently for MeteringLabel it points to Router.tenant_id column which causes
    routers tenant_id clearing on label deletion.

    Closes-Bug: #1249188
    Change-Id: Iccc0daf4f6edd537fd7f9e4b2fc4be094543ca5d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/60477