ExtraRoute_db_mixin._get_extra_routes_by_router_id always returns all routes

[ccoder]

Tonight I created a new router and attached an new subnet to it, then I tried to detach this subnet but failed. I debug the code and found ExtraRoute_db_mixin._get_extra_routes_by_router_id always returns all routes, because of the third line:
1. def _get_extra_routes_by_router_id(self, context, id):
2. query = context.session.query(RouterRoute)
3. query.filter(RouterRoute.router_id == id)
4. return self._make_extra_route_list(query)

   It should be:
          query = query.filter(RouterRoute.router_id == id)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/55532

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/55532
Committed: http://github.com/openstack/neutron/commit/2fb996642a597e7050ecc13ef6f3ad4aaae34997
Submitter: Jenkins
Branch: master

commit 2fb996642a597e7050ecc13ef6f3ad4aaae34997
Author: Oleg Bondarev <email address hidden>
Date: Thu Nov 7 13:35:27 2013 +0400

    ExtraRoute: fix _get_extra_routes_by_router_id()

    router_id filter wasn't properly applied to the query
    so the func returned all extra routes of all routers.

    Closes-Bug: #1248219
    Change-Id: I77733ee7994c8fccbbc966ccabd83b8fe4def8d5