Bulk create need to notify dhcp agent

Bug #1247902 reported by Dong Liu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Dong Liu

Bug Description

I bulk created subnets and ports by neutron api.

Using these ports boot instance. I found that the vms could not get ip address.

Then I saw the source code and found that _send_dhcp_notification function only handle ['network', 'subnet', 'port'] resource.

I think we need to handle collections such as ['networks', 'subnets', 'ports'] here.

Tags: bulk create
Dong Liu (liudong78)
tags: added: bulk create
Dong Liu (liudong78)
Changed in neutron:
assignee: nobody → Dong Liu (liudong78)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/55164

Changed in neutron:
status: New → In Progress
Dong Liu (liudong78)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/55164
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bb2c4ef9a26b12c68ca1e6710d0c92ce00c464cb
Submitter: Jenkins
Branch: master

commit bb2c4ef9a26b12c68ca1e6710d0c92ce00c464cb
Author: liudong <email address hidden>
Date: Tue Nov 5 01:14:50 2013 +0800

    After bulk create send DHCP notification

    In the past send_dhcp_notification only handle single resource
    because of VALID_RESOURCES = ['network', 'subnet', 'port'].
    When I use bulk created ports to boot instance, the VMs could
    not get IP address from DHCP agent. So I add some special handle
    in function notify().

    Add unit test for bulk create dhcp notification.

    Modify a paramter for code style.

    Change-Id: Ibf2b3380dc3081beaf0f2f68042b022f2726bbe7
    Closes-Bug: #1247902

Changed in neutron:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in neutron:
importance: Undecided → Medium
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.