Mix use of test_config['plugin_name_v2'] and plugin argument in DbPluginV2TestCase

Bug #1245335 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki

Bug Description

In NeutronDbPluginV2TestCase and its subclasses (most DB-based tests), there are two ways to specify a core plugin and an extension manager in the unit tests: test_config and "plugin" arguments of the constructor. Both are used and it sometimes makes it a bit difficult to debug.

It is better to unify the way to pass "core plugin" and "extension manager" into one.
I think it is better to remove test_config['plugin_name_v2'] and use "plugin" argument.

Tags: unittest
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/54058

Changed in neutron:
status: New → In Progress
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-1 → icehouse-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/54058
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c15f7226badd0a3607e3c74ef650e87543ea1af7
Submitter: Jenkins
Branch: master

commit c15f7226badd0a3607e3c74ef650e87543ea1af7
Author: Akihiro MOTOKI <email address hidden>
Date: Sat Oct 26 21:53:21 2013 +0900

    Remove plugin_name_v2 and extension_manager in test_config

    There are two ways to specify a core plugin and an extension manager
    in the unit tests: test_config and arguments of the constructor.
    Both are used and it sometimes makes it a bit difficult to debug.
    This patch removes the way via test_config and makes constructor
    arguments the only way to do it.

    Also removes the default entries in test_config because they are
    not used anywhere.

    Change-Id: I491003f4246e62001e9b74743c8fbfa922088383
    Closes-Bug: #1245335

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.