error while creating l2 gateway services in nvp

[Armando Migliaccio]

If a conflict occurs while using the L2 Gateway extension, 500 errors may mask underlying exceptions, For instance:

2013-10-24 07:42:37.709 ERROR NVPApiHelper [-] Received error code: 409
2013-10-24 07:42:37.710 ERROR NVPApiHelper [-] Server Error Message: Device breth0 on transport node dd2e6fb9-98fe-4306-a679-30e15f0af06a is already in use as a gateway in Gateway Service 166ddc25-e617-4cfc-bde5-485a0b622fc6
2013-10-24 07:42:37.710 ERROR neutron.api.v2.resource [-] create failed
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource Traceback (most recent call last):
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/resource.py", line 84, in resource
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource result = method(request=request, **args)
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/base.py", line 411, in create
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource obj = obj_creator(request.context, **kwargs)
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/plugins/nicira/NeutronPlugin.py", line 1921, in create_network_gateway
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource "created resource:%s") % nvp_res)
2013-10-24 07:42:37.710 TRACE neutron.api.v2.resource UnboundLocalError: local variable 'nvp_res' referenced before assignment

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/53660

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/53660
Committed: http://github.com/openstack/neutron/commit/94950eeb22c95da6b2115ea99f6131700decaa09
Submitter: Jenkins
Branch: master

commit 94950eeb22c95da6b2115ea99f6131700decaa09
Author: armando-migliaccio <email address hidden>
Date: Thu Oct 24 08:17:17 2013 -0700

    Fix error while creating l2 gateway services in nvp

    Ensure that Conflict errors are not masked; also ensure
    that coding errors do not mask NVP API errors.

    Fixes bug #1244259

    Change-Id: I27586d72af89fd39f6443dbab33f0e4e762b0c99

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54046

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54046
Committed: http://github.com/openstack/neutron/commit/afc0ff4fe2b6b4148f2fe2c993d1c33c06acfcbb
Submitter: Jenkins
Branch: stable/havana

commit afc0ff4fe2b6b4148f2fe2c993d1c33c06acfcbb
Author: armando-migliaccio <email address hidden>
Date: Thu Oct 24 08:17:17 2013 -0700

    Fix error while creating l2 gateway services in nvp

    Ensure that Conflict errors are not masked; also ensure
    that coding errors do not mask NVP API errors.

    Fixes bug #1244259

    Change-Id: I27586d72af89fd39f6443dbab33f0e4e762b0c99
    (cherry picked from commit 94950eeb22c95da6b2115ea99f6131700decaa09)