iptables manipulation lacks functional testing

Bug #1243216 reported by Maru Newby
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Miguel Angel Ajo

Bug Description

The iptables manipulation in neutron/agent/linux/iptables_manager.py has unit tests but no tests of actual system interaction. This bug is intended to umbrella patches that will add functional testing of such interaction over a representative portion of the module in question.

Tags: l3-ipam-dhcp
Maru Newby (maru)
Changed in neutron:
assignee: nobody → Maru Newby (maru)
Changed in neutron:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: l3-ipam-dhcp
Revision history for this message
Rui Zang (rui-zang) wrote :

Hi Maru,

I have written a simple functional test for IptablesManager and plan to add a series of test cases for iptables.
Could I put these test cases under this umbrella bug and have them reviewed by you?

Thanks.

Rui Zang

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/102749

Changed in neutron:
assignee: Maru Newby (maru) → Jakub Libosvar (libosvar)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/117852
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bc7c8acf90b55a27298484a77a32c089914afb67
Submitter: Jenkins
Branch: master

commit bc7c8acf90b55a27298484a77a32c089914afb67
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 29 18:50:13 2014 +0200

    Add functional test for IptablesManager

    Introduce test of IptablesManager using filtering of ICMP packets in
    namespaces.

    Partial-bug: #1243216

    Change-Id: I90ab0d397780247de619bd90f5febd0e59b84fc7

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118292

Changed in neutron:
assignee: Jakub Libosvar (libosvar) → Miguel Angel Ajo (mangelajo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/118307

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/118308

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: master
Review: https://review.openstack.org/118307
Reason: Issue solved by different patch - https://review.openstack.org/#/c/111715/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/120348

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/120349

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Miguel Angel Ajo (<email address hidden>) on branch: master
Review: https://review.openstack.org/118292
Reason: implemented in https://review.openstack.org/#/c/120087/ refactor

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: master
Review: https://review.openstack.org/120348
Reason: This won't be needed. New patch will come.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: master
Review: https://review.openstack.org/118308
Reason: This won't be needed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/122207

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/125109

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: master
Review: https://review.openstack.org/102749
Reason: This patch has been inactive long enough that I think it's safe to abandon.
The author can resurrect it if needed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/125109
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f1277a4036ac355c13a5b928e189ab2abf765402
Submitter: Jenkins
Branch: master

commit f1277a4036ac355c13a5b928e189ab2abf765402
Author: Jakub Libosvar <email address hidden>
Date: Tue Sep 30 18:13:50 2014 +0200

    Separate wait_until to standalone function

    It makes wait_until more usable outside of unittest.TestCase classes.
    Part of this patch is renaming pinger module to helpers thus we can have
    helpers module with useful utilities for testing.

    Change-Id: Ie8e4854c23aa3739b0df618db1b3944466d64bd2
    Related-Bug: 1243216

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/122207
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=374a612241ff9f15bcdcccb6c60d6d0847706766
Submitter: Jenkins
Branch: master

commit 374a612241ff9f15bcdcccb6c60d6d0847706766
Author: Jakub Libosvar <email address hidden>
Date: Fri Oct 3 14:02:55 2014 +0200

    Add Process class helper to manage processes with namespace

    This class extends Popen class with usage of namespace and root-helper.
    Because of usage of root wrapper, this class re-uses get_child_pid() for
    killing the child process. get_child_pid() is taken out of AsyncProcess
    as a part of this patch.

    Change-Id: I856b3ec75f347ecccaf4a1c6fd17b28a33ee1a3f
    Related-Bug: 1243216

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/120349
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e3fa0112820e6ae95c61b5ebc150e4ba206b3c3c
Submitter: Jenkins
Branch: master

commit e3fa0112820e6ae95c61b5ebc150e4ba206b3c3c
Author: Jakub Libosvar <email address hidden>
Date: Fri Oct 3 18:31:10 2014 +0200

    Add functional tests for IptablesManager using tcp/udp

    This commit adds tests for filter table using tcp and udp protocols.
    Part of it is a NetcatTester class providing ability to test connection
    between two veth pairs in namespaces.

    Change-Id: I6db1e7ffef5e1243478e15a994787396b0908656
    Related-Bug: 1243216

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.