FWaaS - reordering of rules in a policy fails

[Sumit Naiksatam]

There are two issues:

1. When reordering is tried using the update_firewall_policy operation, a FirewallRuleInUse exception is thrown

2. The position of the reordered rules is not correct

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47088

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47088
Committed: http://github.com/openstack/neutron/commit/f521d509db2b38051dbef5e2000d145d37b71672
Submitter: Jenkins
Branch: master

commit f521d509db2b38051dbef5e2000d145d37b71672
Author: Sumit Naiksatam <email address hidden>
Date: Tue Sep 17 23:27:20 2013 -0700

    FWaaS - fix reordering of rules in policy

    Due to a recent change, reodering of rules within the
    same policy was failing. This is fixed by checking if
    the rules belong to the same policy we allow reordering.

    There was also a missing call to reorder due to which
    the position number on the rules was not reflected correctly
    after the reordering. This is also fixed.

    Closes bug: #1226941

    Change-Id: I7f52e8b9d578c290ace3bb615bf68bd213398303