firewall with PENDING_CREATE status cannot be deleted

[Akihiro Motoki]

After the sequence of bug 1223472 was executed, I tried to delete the firewall with PENDING_CREATE status.
delete-firewall operation itself returns successful response, but the firewall itself was not deleted even after waiting five or more minutes.

(Continues from the command sequence of bug 1223472)
The detail sequence of command lines are : http://paste.openstack.org/show/46496/

[Sridar Kandaswamy (skandasw)]

Thanks Akihiro. This is indeed a bug. On the CRUD api's, the code returns without any action if there is no routers present on the specific tenant. Hence a delete does not send back a status msg to the plugin to enable it to purge the firewall from it's tables.

I will fix this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/48704

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/48704
Committed: http://github.com/openstack/neutron/commit/955a966b0b616cca58242ea2841f23f868be058e
Submitter: Jenkins
Branch: master

commit 955a966b0b616cca58242ea2841f23f868be058e
Author: Sridar Kandaswamy <email address hidden>
Date: Fri Sep 27 10:10:35 2013 -0700

    Fix to enable delete of firewall in PENDING_CREATE state

    Firewall will in PENDING_CREATE state if there is no underlying router in the
    tenant. When the router and an associated i/f is created then with a sequence
    of msgs it is set to ACTIVE state by the plugin. If a delete is triggered when
    in PENDING_CREATE state in such a situation, the msg was ignored - fixing this to
    account for the fact that a delete makes sense in this situation so the agent
    sends the appropriate msg back to the plugin so it can delete it.

    Change-Id: Id1db0a8413fd815b518fe4dc57fc6277c09e7f00
    Closes-Bug: #1223478