conversion type missing in log message

Bug #1221036 reported by Kun Huang on 2013-09-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Kun Huang

Bug Description

target codes: (https://github.com/openstack/neutron/blob/master/neutron/plugins/mlnx/agent/eswitch_neutron_agent.py)
  def provision_network(self, port_id, port_mac,
                          network_id, network_type,
                          physical_network, segmentation_id):
        LOG.info(_("Provisioning network %s"), network_id)
        if network_type == constants.TYPE_VLAN:
            LOG.debug(_("creating VLAN Network"))
        elif network_type == constants.TYPE_IB:
            LOG.debug(_("creating IB Network"))
        else:
            LOG.error(_("Unknown network type %(network_type) " <======== miss a conversion type here like 's'
                        "for network %(network_id)"), <======== miss a conversion type here like 's'
                      {'network_type': network_type,
                       'network_id': network_id})
            return
        data = {
            'physical_network': physical_network,
            'network_type': network_type,
            'ports': [],
            'vlan_id': segmentation_id}
        self.network_map[network_id] = data

Changed in neutron:
assignee: nobody → Kun Huang (academicgareth)

Fix proposed to branch: master
Review: https://review.openstack.org/45180

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
Changed in neutron:
milestone: none → havana-rc1

Reviewed: https://review.openstack.org/45180
Committed: http://github.com/openstack/neutron/commit/ee26de1ed22fc67591a7b5465132f78af1f1c0f4
Submitter: Jenkins
Branch: master

commit ee26de1ed22fc67591a7b5465132f78af1f1c0f4
Author: Kun Huang <email address hidden>
Date: Thu Sep 5 14:20:23 2013 +0800

    fix conversion type missing

    Conversion type is missing in some places which would cause some
    unexcepted error. By using 'grep -rn "%(\w\+)\W"', we could find
    all cases of '%(variable_a)' and fix them.

    Change-Id: I05cbaac73976c70be8428bf5a2d0017ea7059cb3
    Closes-Bug: #1221036

Changed in neutron:
status: In Progress → Fix Committed
tags: added: neutron-core
Thierry Carrez (ttx) on 2013-10-03
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers