assertTrue format incorrect in test_extensions.py unit test

[Rajdeep]

Usage of assertTrue/assertFalse needs modification in the unit tests
Change example

from assertTrue(x in y) => assertIn(x,y)
assertFalse(x in y) => assertNotIn(x, y)

Applicable to all the unit test cases

Reference : Similar bug https://bugs.launchpad.net/neutron/+bug/1217028

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44397

[ZhiQiang Fan (aji-zqfan)]

i mark bug/1218706 and bug/1218671 duplicate to this

please fix the assertFalse in the same time

[Rajdeep (dua-rajdeep)]

Uploaded the patch waiting for review

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/230823

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230823
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=49746ca4749c45d2772289061f161145eb5ad2b8
Submitter: Jenkins
Branch: master

commit 49746ca4749c45d2772289061f161145eb5ad2b8
Author: Cedric Brandily <email address hidden>
Date: Sun Oct 4 20:48:44 2015 +0200

    Use assertIn and assertNotIn

    Neutron tests should use:

      self.assertIn(value, list)
      self.assertNotIn(value, list)

    instead of:

      self.assertTrue(value in list)
      self.assertFalse(value in list)

    because assertIn and assertNotIn raise more meaningful errors:

      self.assertIn(3, [1, 2]
      >>> MismatchError: 3 not in [1, 2]

      self.assertTrue(3 in [1, 2])
      >>> AssertionError: False is not true

    Closes-Bug: #1218713

    Change-Id: Ic8492a88935bf005feb9dae726a4bee604a8bd09

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/231286

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/232292

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/233167

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/236846

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bertrand Lallau (<email address hidden>) on branch: master
Review: https://review.openstack.org/236846

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231286
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=5687a4af599172970c8b90d6a27c3a9b20b00ff5
Submitter: Jenkins
Branch: master

commit 5687a4af599172970c8b90d6a27c3a9b20b00ff5
Author: Reedip Banerjee <email address hidden>
Date: Tue Oct 6 07:01:43 2015 +0530

    Use assert(Not)In instead of assertTrue/False

    Neutron tests should use:

    self.assertIn(value, list) and
    self.assertNotIn(value, list)

    instead of:

    self.assertTrue(value in list) and
    self.assertFalse(value in list)

    because assertIn and assertNotIn raise more meaningful errors:

    self.assertIn(3, [1, 2])
    >>> MismatchError: 3 not in [1, 2]

    self.assertTrue(3 in [1, 2])
    >>> AssertionError: False is not true

    To enforce this improvement, this patch is created.

    Change-Id: Ia2ca003829858cceda181da41dea4f70a3d48d45
    Related-Bug: #1218713

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232292
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=67b7d925838739642a61c65094faf73ca338208f
Submitter: Jenkins
Branch: master

commit 67b7d925838739642a61c65094faf73ca338208f
Author: Kenji Yasui <email address hidden>
Date: Wed Oct 7 07:34:37 2015 +0000

    Use assert(Not)In instead of assertTrue/False

    Neutron tests should use:

    self.assertIn(value, list) and
    self.assertNotIn(value, list)

    instead of:

    self.assertTrue(value in list) and
    self.assertFalse(value in list)

    because assertIn and assertNotIn raise more meaningful errors:

    self.assertIn(3, [1, 2])
    >>> MismatchError: 3 not in [1, 2]

    self.assertTrue(3 in [1, 2])
    >>> AssertionError: False is not true

    To enforce this improvement, this patch is created.

    Change-Id: I4a05ad5a5ff9674dd94cff8b11585fd39dc264b3
    Related-Bug: #1218713

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/233167
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.