fix i18n messages

Bug #1217100 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
ZhiQiang Fan
python-neutronclient
Fix Released
High
Sergio Cazzolato

Bug Description

As some new feature is added, i18n support for message is broken **again**, for, i.e. https://github.com/openstack/neutron/blob/master/neutron/plugins/cisco/nexus/cisco_nexus_plugin_v2.py#L112 and there are more.

messages can be divided to 4 parts:
1) log message <-- important
2) exception message <-- important
3) print message <-- important
3) opt help message <-- need discussion

 i think all of them need i18n support, because these messages will be exposed to end-client-user/operators.

If neutron-drivers think this is invalid, then please change its status then i will stop.

Tags: neutron-core
ZhiQiang Fan (aji-zqfan)
Changed in neutron:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Changed in python-neutronclient:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
ZhiQiang Fan (aji-zqfan)
description: updated
ZhiQiang Fan (aji-zqfan)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43804

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → High
milestone: none → havana-3
Changed in python-neutronclient:
importance: Undecided → High
status: New → Confirmed
milestone: none → 2.2.1
Akihiro Motoki (amotoki)
Changed in neutron:
milestone: havana-3 → havana-rc1
tags: added: neutron-core
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/43804
Committed: http://github.com/openstack/neutron/commit/9842dcb34cb79b942391fdab4a00dd790b5e299e
Submitter: Jenkins
Branch: master

commit 9842dcb34cb79b942391fdab4a00dd790b5e299e
Author: ZhiQiang Fan <email address hidden>
Date: Tue Aug 27 08:02:04 2013 +0800

    Fix message i18n error

    Partial-Bug: #1217100

    Using tools/check_i18n.py to scan source directory, and fix most of
    the errors.

    - Message internationalization
    - First letter must be capital
    - Using comma instead of percent in LOG.xxx

    Note: all extension's description are not touched in this patch,
    can be fixed after discussing.
    Note: all nicira/check_nvp_config.py print messages are not fixed.

    Change-Id: I79ef06fd42f6780beb5019c592662536c2a51864

ZhiQiang Fan (aji-zqfan)
Changed in python-neutronclient:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
Changed in python-neutronclient:
assignee: nobody → Sergio Cazzolato (sergio-j-cazzolato)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57522

Changed in python-neutronclient:
status: Confirmed → In Progress
Changed in python-neutronclient:
status: In Progress → Fix Committed
Changed in python-neutronclient:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/57522
Committed: http://github.com/openstack/python-neutronclient/commit/6d937f3e8591716058961782c1e012a4a8d7702a
Submitter: Jenkins
Branch: master

commit 6d937f3e8591716058961782c1e012a4a8d7702a
Author: Sergio Cazzolato <email address hidden>
Date: Fri Nov 15 23:18:59 2013 -0500

    Fix i18n messages in neutronclient

    Using tools/check_i18n.py to scan source directory, and fix most of
    the errors.
        - Message internationalization
        - First letter must be capital
        - Using comma instead of percent in LOG.xxx

    Partial-Bug: #1217100
    Change-Id: I312f999f97e33d84c3f06fa1caacf32affc26a78

Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: 2.2.1-2.2.6 → none
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 2.3.0-2.3.4
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
Revision history for this message
Akihiro Motoki (amotoki) wrote :

As of Dec 2015, the help message looks correct.

  --peer-address PEER_ADDRESS
                        Peer gateway public IPv4/IPv6 address or FQDN.
  --peer-id PEER_ID Peer router identity for authentication. Can be
                        IPv4/IPv6 address, e-mail address, key id, or FQDN.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

woops.... I commented to a wrong bug.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers