REST API translation not always working

[Luis A. Garcia]

Messages that include replacements need to be invoked twice in order to be translated.

For example:

Request 1:
GET /v2.0/agents/blah
Accept-Language: es

Response:
{
NeutronError: "Agent blah could not be found"
}

Then the second time:

Request 2:
GET /v2.0/agents/blah
Accept-Language: es

{
NeutronError: "El Agente blah no fue encontrado."
}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/42387

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/42387
Committed: http://github.com/openstack/neutron/commit/7e2622c2fc89611a34c242792f46572545bcdffb
Submitter: Jenkins
Branch: master

commit 7e2622c2fc89611a34c242792f46572545bcdffb
Author: Luis A. Garcia <email address hidden>
Date: Fri Aug 16 16:07:47 2013 +0000

    Enhance exception translation to better handle NeutronExceptions

    NeutronExceptions have a 'message' class attribute that holds the
    generic error message template, e.g. "Network %(network)s not found",
    unfortunately, because the names are the same, it was overshadowing the
    actual exception instance 'message', e.g. "Network 1 not found", after
    translation when the exception was serialized to JSON.

    This patch puts the exception's actual message in a new field called
    'msg' and overwrites NeutronException unicode() so that 'msg' is used
    during serialization and we'll get the correct message on the REST API
    response.

    Fixes bug: #1212882

    Change-Id: I3965bffb1c2c2eee0af440d1ecd30ccb3bb958d5