remove openstack.common.context

Bug #1210261 reported by ZhiQiang Fan
28
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Yuriy Nesenenko
Glance
Fix Released
Undecided
ZhiQiang Fan
OpenStack Compute (nova)
Fix Released
Low
Tomofumi Hayashi
neutron
Fix Released
Undecided
Unassigned
oslo.log
Fix Released
Low
Davanum Srinivas (DIMS)

Bug Description

relates to https://bugs.launchpad.net/neutron/+bug/1208734, and according to https://github.com/openstack/oslo-incubator/blob/master/MAINTAINERS#L87, i think we'd better remove openstack/comon/context

Tags: oslo cleanup
ZhiQiang Fan (aji-zqfan)
Changed in neutron:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/41022

Changed in neutron:
status: New → In Progress
ZhiQiang Fan (aji-zqfan)
Changed in neutron:
status: In Progress → Incomplete
ZhiQiang Fan (aji-zqfan)
affects: neutron → glance
affects: glance → neutron
Changed in cinder:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Changed in glance:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Changed in nova:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Changed in oslo:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Changed in neutron:
status: Incomplete → In Progress
tags: added: oslo
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Mark McLoughlin (markmc)
Changed in oslo:
status: New → Triaged
importance: Undecided → Low
tags: added: cleanup
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :
Changed in glance:
status: New → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
ZhiQiang Fan (aji-zqfan)
Changed in nova:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Changed in cinder:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Changed in oslo:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Changed in neutron:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
assignee: nobody → ZhiQiang Fan (aji-zqfan)
ZhiQiang Fan (aji-zqfan)
Changed in neutron:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Mike Perez (thingee)
Changed in cinder:
status: New → Triaged
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-2 → 2014.1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Rather than removing the use of the common context class, the oslo team would like to have applications use it as the base class for their custom contexts. That way we have a place to declare the API expected by the ContextHandler in oslo.log, and we can share some common code for creating application-agnostic logging configurations (https://blueprints.launchpad.net/oslo/+spec/app-agnostic-logging-parameters).

Revision history for this message
Allison Randal (allison) wrote :

Also https://etherpad.openstack.org/p/juno-oslo-release-plan, for more details. Doug also mentioned that oslo.log is likely to graduate later in Juno, which will affect the timing on this bug.

Changed in oslo.log:
status: New → Triaged
no longer affects: oslo-incubator
Changed in oslo.log:
importance: Undecided → Low
Changed in neutron:
assignee: nobody → Cedric Brandily (cbrandily)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Cedric Brandily (<email address hidden>) on branch: master
Review: https://review.openstack.org/130778

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cinder (master)

Reviewed: https://review.openstack.org/137157
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9d17fa6dc855fdba1e9f6c804b4a69a99c0c362e
Submitter: Jenkins
Branch: master

commit 9d17fa6dc855fdba1e9f6c804b4a69a99c0c362e
Author: Adrien Vergé <email address hidden>
Date: Wed Nov 26 15:24:46 2014 +0100

    Inherit RequestContext from oslo

    In the long-term, OpenStack projects should use oslo.context as the base
    class for their custom contexts. This enables the use of
    application-agnostic tools, e.g. global logging configurations. See
    http://specs.openstack.org/openstack/oslo-specs/specs/juno/app-agnostic-logging-parameters.html

    This patch syncs the latest context module from oslo-incubator and use
    it as the base class for Cinder RequestContext. The goal is to clean up
    Cinder code, and to be ready for the first oslo.context release.

    Change-Id: Iba9354b402de556ca6e55e7c17dd6f3f1624d72d
    Related-bug: #1210261

Changed in oslo.log:
status: Triaged → Fix Committed
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Ivan Kolodyazhny (e0ne)
Changed in cinder:
assignee: nobody → Ivan Kolodyazhny (e0ne)
Changed in cinder:
assignee: Ivan Kolodyazhny (e0ne) → Yuriy Nesenenko (ynesenenko)
Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/144108
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dfaaa2ecbdc8c87d42bd89bc0c42b80318895974
Submitter: Jenkins
Branch: master

commit dfaaa2ecbdc8c87d42bd89bc0c42b80318895974
Author: Yuriy Nesenenko <email address hidden>
Date: Fri Dec 26 12:00:52 2014 +0200

    Replace oslo-incubator with oslo_context

    Context currently being moved out of the incubator to a standalone project.

    Change-Id: I4f25ed35a88f82ee934cc35872c66d7a38256408
    Closes-Bug: #1210261

Changed in cinder:
status: In Progress → Fix Committed
Changed in oslo.log:
milestone: none → 0.1.0
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Changed in neutron:
assignee: Cedric Brandily (cbrandily) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154557

Changed in nova:
assignee: nobody → Tomofumi Hayashi (s1061123)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/154557
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=24fd271994907f669ad9f38e7c1de5bc0ce6c52a
Submitter: Jenkins
Branch: master

commit 24fd271994907f669ad9f38e7c1de5bc0ce6c52a
Author: Tomofumi Hayashi <email address hidden>
Date: Sat Feb 14 04:40:41 2015 +0900

    Replace oslo-incubator with oslo_context

    openstack.common.context is currently moved out of the incubator
    to a standalone project, hence replace it with oslo_context in nova.

    Change-Id: I6cbf5d719f33072a5a871c250760512a439a7daf
    Closes-Bug: #1210261

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-2 → 2015.1.0
Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Aditi Rajagopal (aditirajagopal) wrote :

Looks like this was taken care of here - https://review.openstack.org/#/c/194844/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.