Minor fixes for comments in merged firewall API patch

[Sumit Naiksatam]

neutron/db/firewall/firewall_db.py

222 def _get_port_range_from_min_max_ports(self, min_port, max_port):
223 if not min_port:
224 return None
225 if min_port == max_port:
226 return str(min_port)
227 else:
228 return str(min_port) + ':' + str(max_port)
mark mcclain 7:48 AM
In a follow up patch..
return '%d:%d' % (min_port, max_port)
Reply ...

211 def _get_min_max_ports_from_range(self, port_range):
212 if not port_range:
213 return [None, None]
214 ports = port_range.split(':')
Paul Michali 4:32 AM
You could do...
min_port, sep, max_port = port_range.partition(":")
if not max_port:
    max_port = min_port
return [int(min_port), int(max_port)]

neutron/extensions/firewall.py
class FirewallRuleInfoMissing(qexception.InvalidInput):
88 message = _("Missing rule info argument for insert/remove "
89 "rule opertaion.")
Armando Migliaccio 10:17 AM
grammar nit.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39638

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39638
Committed: http://github.com/openstack/neutron/commit/ab1a932872a6ff7821b7723879d6d75ab3b7154f
Submitter: Jenkins
Branch: master

commit ab1a932872a6ff7821b7723879d6d75ab3b7154f
Author: Sumit Naiksatam <email address hidden>
Date: Wed Jul 31 23:25:59 2013 -0700

    Followup fixes to FWaaS API patch

    Fixes: bug #1206620

    This adds the minor fixes which were suggested be fixed
    as a followup to the FWaaS API patch.

    Change-Id: I8112dcb4f750bb367dcc6464cda7a826b7be811e