ML2 plugin needs to override bulk operations

Bug #1193861 reported by Andre Pech
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Mohammad Banikazemi

Bug Description

Bulk operations on the ML2 plugin will simply call each action sequentially within one transaction. This means that errors raised by a mechanism driver in a _postcommit action will cause all transactions to be undone.

The ML2 plugin should override these bulk operations to:
    * make all pretransaction commit calls (ie call the appropriate _precommit methods on all registered mechansim drivers)
    * commit the transaction
    * make all post-transaction commit calls (ie call the appropriate _postcommit methods on all registered mechanism drivers)

If an error occurs after committing the transaction, we'll need to decide how to appropriately undo the operations that have been taken so far.

Tags: ml2
tags: added: ml2
Changed in quantum:
importance: Undecided → Medium
status: New → Triaged
Andre Pech (apech-o)
Changed in neutron:
assignee: nobody → Andre Pech (apech-o)
Shiv Haris (shh)
Changed in neutron:
milestone: none → juno-3
Shiv Haris (shh)
Changed in neutron:
assignee: Andre Pech (apech-o) → Mohammad Banikazemi (mb-s)
Changed in neutron:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113999

Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → juno-rc1
Revision history for this message
Kyle Mestery (mestery) wrote :

Moving medium priority bug out of Juno-RC1.

Changed in neutron:
milestone: juno-rc1 → kilo-1
Revision history for this message
Kyle Mestery (mestery) wrote :

Per my own confusion, moving back to Juno-RC1.

Changed in neutron:
milestone: kilo-1 → juno-rc1
Revision history for this message
Kyle Mestery (mestery) wrote :

Adding a -1 because we're likely to cut RC1 on Monday and this won't make it. We can consider for RC2 if we have to cut an RC2.

Changed in neutron:
milestone: juno-rc1 → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: master
Review: https://review.openstack.org/113999
Reason: This patch has been inactive long enough that I think it's safe to abandon.
The author can resurrect it if needed.

Changed in neutron:
status: In Progress → Confirmed
Changed in neutron:
status: Confirmed → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: kilo-1 → none
Changed in neutron:
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/113999
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2ee08c3464c53abaf9bc5493132ad7958611e3b8
Submitter: Jenkins
Branch: master

commit 2ee08c3464c53abaf9bc5493132ad7958611e3b8
Author: Mohammad Banikazemi <email address hidden>
Date: Sat Sep 6 10:24:01 2014 -0400

    Move postcommit ops out of transaction for bulk

    Currently, the bulk create operations in ML2 are executed in
    a transaction. This means all precommit and postcommit operations
    for such operations are in a transaction. Postcommit operations
    are expected to be executed outside of transactions as they may
    communicate with a backend and introduce substantial delays. This
    fix removes the postcommit operations from the transaction for
    bulk create network/subnet/port operations.

    Change-Id: I9a9683058088e50d9443040223232bf5e1396ccf
    Closes-Bug: #1193861

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-2 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/188992

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/juno)

Change abandoned by stephen-ma (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/188992

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers