goodbye and good riddance, run_tests.sh

Bug #1172012 reported by Aaron Rosen on 2013-04-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Low
Unassigned

Bug Description

Quantum has been using tox for more than 6 months now, and it's about time to remove run_tests.sh, which apparently does not even work anymore.

This bug description has been updated to reflect consensus from the community.

Changed in quantum:
status: New → Confirmed
Maru Newby (maru) wrote :

This is likely the result of having switched to testr but run_test.sh not having been updated. Note that the way the gate runs it is 'tox -e pep8', and this still works. Invoking flake8 directly also works, and will pick up the configuration from tox.ini

There was a session at the summit questioning whether run_tests.sh should persist given that tox can do the same thing and maintaining parity isn't free. Another concern was that run_tests.sh hides the underlying command being executed from developers, and it might be preferable to require people to invoke a given command directly so that they can have the opportunity to discover more advanced features (e.g. testr --failing).

So, should this bug be fixed, or might it be preferable to seek consensus on removal of run_tests.sh instead?

I seem to recall there's a sort of consensus of getting rid of ./run_tests.sh

Other project already said goodbye to it.
Perhaps if nobody comments here for 72 hours about keeping it we can just convert this bug report to "Remove run_tests.sh"

I agree with removing run_tests.sh. Having two ways to do the same thing may spark confusion.

Mark McClain (markmcclain) wrote :

My vote is to remove run_tests.sh.

Changed in quantum:
importance: Undecided → Low
tags: added: unittest
Akihiro Motoki (amotoki) wrote :

I agree with removing run_tests.sh.

run_tests.sh was updated wrongly when testr was introduced.

yong sheng gong (gongysh) wrote :

me too

I think we have enough consensus now regarding its removal.
If anybody feels it shouldn't be removed, there's time until the patch is merged.

summary: - ./run_tests.sh -pep8 no longer works
+ goodbye and good riddance, run_tests.sh
description: updated
Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)

Fix proposed to branch: master
Review: https://review.openstack.org/27695

Changed in quantum:
status: Confirmed → In Progress
Aaron Rosen (arosen) wrote :

My only gripe is when i run: tox -e pep8 is that it creates a .tox/_download and installs all the dependencies even if I have them installed already on my system. Using ./run_test.sh -N --pep8 in grizzly would allow me to avoid this. Is there an arg to tox i'm missing?

I think everybody agrees with the slowness of tox, especially when setting
up the venv.

Since a few people voted for getting rid of it, I went ahead and deleted it.
The act of threatening to kill run_tests however woke up its supporters.

Therefore we should now think of fixing and maintaining it.
Il giorno 30/apr/2013 10:45, "Aaron Rosen" <email address hidden> ha scritto:

> My only gripe is when i run: tox -e pep8 is that it creates a
> .tox/_download and installs all the dependencies even if I have them
> installed already on my system. Using ./run_test.sh -N --pep8 in
> grizzly would allow me to avoid this. Is there an arg to tox i'm
> missing?
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/1172012
>
> Title:
> goodbye and good riddance, run_tests.sh
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> Quantum has been using tox for more than 6 months now, and it's about
> time to remove run_tests.sh, which apparently does not even work
> anymore.
>
> This bug description has been updated to reflect consensus from the
> community.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1172012/+subscriptions
>

Henry Gessau (gessau) wrote :

I am not a supporter of run_tests per se, but I did use it for a couple of things, so when I saw it going away I had to look for new ways to do those things.

1) Instantly run one individual function or class unit test. For this tox is too clunky. Nosetests was mentioned but I have not figured how to use that yet.

2) Run a unit test in the debugger. For this I use(d) "python run_tests.py the.required.unit.test". Thus I would like to keep run_tests.py unless there is an alternative.

Henry Gessau (gessau) wrote :

We should also update .gitignore:

 build-stamp
 ChangeLog
 .coverage
-covhtml/
+cover/
 doc/build
 *.DS_Store
 *.pyc
 quantum.egg-info/
 quantum/vcsversion.py
 quantum/versioninfo
 run_tests.err.log
 run_tests.log
 setuptools*.egg/
 subunit.log
 .testrepository
 .tox/
-.venv/
 *.mo

Changed in neutron:
assignee: Salvatore Orlando (salvatore-orlando) → nobody
Cedric Brandily (cbrandily) wrote :

This bug is > 365 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
status: In Progress → Incomplete
Launchpad Janitor (janitor) wrote :

[Expired for neutron because there has been no activity for 60 days.]

Changed in neutron:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers