NVP net-gateway extension fail when invalid parameter supplied

Bug #1171926 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Salvatore Orlando

Bug Description

quantum net-gateway-create --device id=4a8f2a88-282e-4aab-b08e-ce51ab04e420,invalid_param=foo gw_name
Request Failed: internal server error while processing your request.

There's no attribute named 'invalid_param' in the device list.
This escapes the dict validator which lets extra attributes go in anyway. In the case of this particular extension the unknown parameter is supplied to the model class thus causing the crash.

Tags: api nicira
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27391

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/27391
Committed: http://github.com/openstack/quantum/commit/01a977b66958ec1d03964bbe3aaf218ff044232b
Submitter: Jenkins
Branch: master

commit 01a977b66958ec1d03964bbe3aaf218ff044232b
Author: Salvatore Orlando <email address hidden>
Date: Wed Apr 24 02:11:07 2013 +0200

    Send 400 error if device specification contains unexpected attributes

    Bug #1171926

    This patch simply enhances the validator for the 'devices' attribute
    by verifying each element in the device list does not contain
    unexpected attributes.

    Change-Id: Id3fd182a7f711b482ad371752983264ad73b100f

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.