Update Brocade plugin to support "report_state" rpc call

[Shiv Haris]

With changes in agent code - which now sends rpc for method "report_state", Brocade plugin (q-server) will fail this call.

[Shiv Haris (shh)]

q-svc log showing failure:

2013-03-06 11:54:32.077 8844 DEBUG quantum.openstack.common.rpc.amqp [-] received {u'_context_roles': [u'admin'], u'_msg_id': u'c1edbca0d2f946d8b87e344c1a3aaab6', u'_context_read_deleted': u'\
no', u'_context_tenant_id': None, u'args': {u'agent_state': {u'agent_state': {u'binary': u'quantum-linuxbridge-agent', u'start_flag': True, u'topic': u'N/A', u'host': u'u5', u'agent_type': u'\
Linux bridge agent', u'configurations': {u'devices': 0}}}}, u'_unique_id': u'de44f017d60f44e5aa3d5849a4e741cf', u'_context_is_admin': True, u'version': u'1.0', u'_context_project_id': None, u\
'_context_timestamp': u'2013-03-06 19:52:42.923326', u'_context_user_id': None, u'method': u'report_state'} _safe_log /opt/stack/quantum/quantum/openstack/common/rpc/common.py:254
2013-03-06 11:54:32.079 8844 DEBUG quantum.openstack.common.rpc.amqp [-] unpacked context: {'user_id': None, 'roles': [u'admin'], 'tenant_id': None, 'is_admin': True, 'timestamp': u'2013-03-0\
6 19:52:42.923326', 'project_id': None, 'read_deleted': u'no'} _safe_log /opt/stack/quantum/quantum/openstack/common/rpc/common.py:254
2013-03-06 11:54:32.082 8844 ERROR quantum.openstack.common.rpc.amqp [-] Exception during message handling
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp Traceback (most recent call last):
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp File "/opt/stack/quantum/quantum/openstack/common/rpc/amqp.py", line 429, in _process_data
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp File "/opt/stack/quantum/quantum/common/rpc.py", line 43, in dispatch
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp quantum_ctxt, version, method, **kwargs)
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp File "/opt/stack/quantum/quantum/openstack/common/rpc/dispatcher.py", line 136, in dispatch
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp raise AttributeError("No such RPC function '%s'" % method)
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp AttributeError: No such RPC function 'report_state'
2013-03-06 11:54:32.082 8844 TRACE quantum.openstack.common.rpc.amqp
2013-03-06 11:54:32.085 8844 ERROR quantum.openstack.common.rpc.common [-] Returning exception No such RPC function 'report_state' to caller
2013-03-06 11:54:32.086 8844 ERROR quantum.openstack.common.rpc.common [-] ['Traceback (most recent call last):\n', ' File "/opt/stack/quantum/quantum/openstack/common/rpc/amqp.py", line 429\
, in _process_data\n rval = self.proxy.dispatch(ctxt, version, method, **args)\n', ' File "/opt/stack/quantum/quantum/common/rpc.py", line 43, in dispatch\n quantum_ctxt, version, meth\
od, **kwargs)\n', ' File "/opt/stack/quantum/quantum/openstack/common/rpc/dispatcher.py", line 136, in dispatch\n raise AttributeError("No such RPC function \'%s\'" % method)\n', "Attribu\
teError: No such RPC function 'report_state'\n"]
2013-03-06 11:54:32.088 8844 DEBUG quantum.openstack.common.rpc.amqp [-]...

[Shiv Haris (shh)]

I will push out the review. It requires some imports as well. I'll let Dan decide how to handle merge timing on this one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23764

[Akihiro Motoki (amotoki)]

Hi Shiv,
Did you see the above traceback once per linux bridge agent? If so, it is a expected behavior.
If the agent receives an error in report_state RPC, then it fallbacks to the legacy mode without report state.

[Akihiro Motoki (amotoki)]

Sorry for my mistake....... That is a behavior of dhcp-agent and l3-agent.
I was confused dhcp/l3-agent and linux bridge agent.
The linuxbridge agent does not have this feature. Your report is valid.

[Shiv Haris (shh)]

Hi Akihiro,

No this ERROR traceback happens every couple of seconds, repeated for ever.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23764
Committed: http://github.com/openstack/quantum/commit/4ee4e75321cc163c9f5a9e0d3e159211357ca3a0
Submitter: Jenkins
Branch: master

commit 4ee4e75321cc163c9f5a9e0d3e159211357ca3a0
Author: Shiv Haris <email address hidden>
Date: Wed Mar 6 15:25:49 2013 -0800

    Enable handling the report_state RPC call in Brocade Plugin

    Fixes: bug #1150294

    Change-Id: I4f641af48140a108e7c707446cda52509d567c8d