multiline import statement causes RPM build failures

Bug #1148252 reported by Dan Prince
This bug report is a duplicate of:  Bug #1148133: New install of Quantum failed. Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Committed
Undecided
Dan Prince

Bug Description

Using the latest Grizzly quantum code I'm now getting RPM build failures:

Bytecompiling .py files below /root/rpmbuild/BUILDROOT/openstack-quantum-2013.1.a131.gaca76b0-0.1.2142.aca76b0_3aec1b8.x86_64/usr/lib/python2.7/ using /usr/bin/python2.7
Compiling /root/rpmbuild/BUILDROOT/openstack-quantum-2013.1.a131.gaca76b0-0.1.2142.aca76b0_3aec1b8.x86_64/usr/lib/python2.7/site-packages/quantum/plugins/cisco/extensions/credential.py ...
SyntaxError: ('invalid syntax', ('/usr/lib/python2.7/site-packages/quantum/plugins/cisco/extensions/credential.py', 28, 5, '(from quantum.plugins.cisco.extensions import _credential_view as\n'))

error: Bad exit status from /var/tmp/rpm-tmp.qaTjAa (%install)

----

If at all possible it would be nice to avoid multi-line import statements.

Dan Prince (dan-prince)
Changed in quantum:
assignee: nobody → Dan Prince (dan-prince)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23641

Revision history for this message
dan wendlandt (danwent) wrote :
Revision history for this message
dan wendlandt (danwent) wrote :

note: that change fixes the import error, but keeps the import line as multi-line. Currently quantum does not have a style guideline that prohibits multi-line imports, and others exist in the code-base. Better to handle that as a full pass if its something we think we should enforce.

Revision history for this message
Dan Prince (dan-prince) wrote :

Thanks. This seems to be fixed in 1148133.

Changed in quantum:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.