Return 501 for not implemented action

Bug #1146586 reported by Alex Xu on 2013-03-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Wishlist
Unassigned

Bug Description

We haven't conistent return code for non-implemented action.

QuotaSetsController.create returns 500
AgentPluginBase.create_agent returns 404
ExtensionController.delete/create return 404
NetworkSchedulerController.update/show return 500
RouterSchedulerController.update/show return 500
DhcpAgentsHostingNetworkController.create/delete/update/show return 500
L3AgentsHostingRouterController.create/delete/update/show return 500

As discusstion at https://review.openstack.org/#/c/23406/5/quantum/extensions/quotasv2.py

We prefer use 501 for this case

Alex Xu (xuhj) on 2013-03-05
Changed in quantum:
assignee: nobody → Alex Xu (xuhj)
Alex Xu (xuhj) on 2013-03-05
summary: - Return 403 for not implemented action
+ Return 501 for not implemented action
description: updated
Nachi Ueno (nati-ueno) wrote :

We need to discuss this quickly, because this is the API change.
I prefer we should use 501 for this case.

Changed in quantum:
importance: Undecided → High
status: New → Confirmed
Sumit Naiksatam (snaiksat) wrote :

Agree, ideally this should be consistent and 501 seems like the right choice.

Fix proposed to branch: master
Review: https://review.openstack.org/23664

Changed in quantum:
status: Confirmed → In Progress

I wonder for which reason API changes came up always in RC period.
Usually anything that we quickly discuss and decide never ends up well :)

I am happy with raising a 501.
I am nervous about the proposed change that potentially affects all existing extensions.

tags: added: api

Yeah, I think we should shut down all of these "nice to have" API changes.

dan

On Wed, Mar 6, 2013 at 6:46 AM, Salvatore Orlando <
<email address hidden>> wrote:

> I wonder for which reason API changes came up always in RC period.
> Usually anything that we quickly discuss and decide never ends up well :)
>
> I am happy with raising a 501.
> I am nervous about the proposed change that potentially affects all
> existing extensions.
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/1146586
>
> Title:
> Return 501 for not implemented action
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> We haven't conistent return code for non-implemented action.
>
> QuotaSetsController.create returns 500
> AgentPluginBase.create_agent returns 404
> ExtensionController.delete/create return 404
> NetworkSchedulerController.update/show return 500
> RouterSchedulerController.update/show return 500
> DhcpAgentsHostingNetworkController.create/delete/update/show return 500
> L3AgentsHostingRouterController.create/delete/update/show return 500
>
> As discusstion at
> https://review.openstack.org/#/c/23406/5/quantum/extensions/quotasv2.py
>
> We prefer use 501 for this case
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1146586/+subscriptions
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Changed in quantum:
importance: High → Wishlist
Alex Xu (xuhj) on 2013-08-25
Changed in neutron:
assignee: Alex Xu (xuhj) → nobody
status: In Progress → New
Changed in neutron:
assignee: nobody → Justin Hammond (justin-hammond)
Justin Hammond (justin-hammond) wrote :

Is this still a viable bug? I have time and I want to fix whatever I can.

You might want to have a look at bug 1197200, because a few of them might have already been fixed (most likely the ones that return 500)

Justin Hammond (justin-hammond) wrote :

I will look to see if this is still happening.

Changed in neutron:
status: New → Triaged
tags: added: low-hanging-fruit
Changed in neutron:
status: Triaged → Incomplete
Changed in neutron:
assignee: Justin Hammond (justin-hammond) → nobody
PSargent (petra-sargent) on 2015-10-28
Changed in neutron:
assignee: nobody → PSargent (petra-sargent)

This bug is > 240 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: PSargent (petra-sargent) → nobody
Launchpad Janitor (janitor) wrote :

[Expired for neutron because there has been no activity for 60 days.]

Changed in neutron:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers