firewall driver is an abstract class not using abstractmethod

Bug #1119119 reported by Isaku Yamahata
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Dariusz Smigiel

Bug Description

FirewallDrifver uses @abstractmethod decorator, but it doesn't set its metaclass to ABCMeta.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21495

Changed in quantum:
assignee: nobody → Isaku Yamahata (yamahata)
status: New → In Progress
Changed in quantum:
importance: Undecided → Low
tags: added: low-hanging-fruit sg-fw
Changed in neutron:
assignee: Isaku Yamahata (yamahata) → nobody
status: In Progress → Won't Fix
Revision history for this message
Cedric Brandily (cbrandily) wrote :

That's the opposite: FirewallDriver is an abstract class using the pattern:

 def method(...):
    raise NotImplementedError

instead of:

 @abstractmethod
 def method(...):
   pass

Changed in neutron:
status: Won't Fix → Confirmed
summary: - firewall driver uses abstracemethod without metaclass set
+ firewall driver is an abstract class not using abstractmethod
Changed in neutron:
assignee: nobody → Dariusz Smigiel (smigiel-dariusz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239403

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/239403
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e9ee5bd308bedd09eed1bf436852ec9898395ffc
Submitter: Jenkins
Branch: master

commit e9ee5bd308bedd09eed1bf436852ec9898395ffc
Author: Dariusz Smigiel (dasm) <email address hidden>
Date: Mon Oct 26 12:12:38 2015 +0100

    Add abstractmethod to FirewallDriver abstract class

    FirewallDriver is abstract base class but do not have abstractmethods.
    Updated methods to correspond with use-case of class.

    Closes-bug: #1119119
    Change-Id: I4b27b27d66c0b89cd9b65541cc1703103a2b00d2

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.