dhcp-agent distributes empty domain when dhcp_domain=""

Bug #1099625 reported by Nachi Ueno
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Nachi Ueno
Folsom
Fix Released
Medium
Gary Kotton

Bug Description

dhcp-agent distributes empty domain when dhcp_domain=""

This line should check value of dhcp_domin.
https://github.com/openstack/quantum/blob/master/quantum/agent/linux/dhcp.py#L224

Changed in quantum:
assignee: nobody → Wu Wenxiang (wu-wenxiang)
Revision history for this message
Wu Wenxiang (wu-wenxiang) wrote :

Which one is better, report "Config Error" or ignore dhcp_domain args in the cmds ?

Changed in quantum:
status: New → In Progress
Gary Kotton (garyk)
tags: added: folsom-backport-potential
Changed in quantum:
assignee: Wu Wenxiang (wu-wenxiang) → Nachi Ueno (nati-ueno)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/19717
Committed: http://github.com/openstack/quantum/commit/c63e0465d047413b71dd616249bbbe2efddbf0f9
Submitter: Jenkins
Branch: master

commit c63e0465d047413b71dd616249bbbe2efddbf0f9
Author: Nachi Ueno <email address hidden>
Date: Tue Jan 15 09:54:59 2013 -0800

    Disable dhcp_domain distribution when dhcp_domain is empty

    fixes bug 1099625

    Change-Id: Ib86770345c46a0dd8bb38a4c3e435420170828af

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/20785

Mark McLoughlin (markmc)
tags: removed: folsom-backport-potential
Akihiro Motoki (amotoki)
Changed in quantum:
milestone: none → grizzly-3
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (stable/folsom)

Reviewed: https://review.openstack.org/20785
Committed: http://github.com/openstack/quantum/commit/2f3279502356008b69e3e43e210c86c1c9e659fe
Submitter: Jenkins
Branch: stable/folsom

commit 2f3279502356008b69e3e43e210c86c1c9e659fe
Author: Nachi Ueno <email address hidden>
Date: Tue Jan 15 09:54:59 2013 -0800

    Disable dhcp_domain distribution when dhcp_domain is empty

    fixes bug 1099625

    Change-Id: Ib86770345c46a0dd8bb38a4c3e435420170828af

Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers