Drop lxml dependency, instead rely upon xml.etree package

Bug #1068290 reported by Jonathan LaCour
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Zhongyue Luo

Bug Description

Quantum currently depends on lxml, when it doesn't need to. We should change to just import xml.etree instead.

Revision history for this message
Gary Kotton (garyk) wrote :

Hi,
Can you please clarify why this needs to be done? I am not familiar with the differences.
Thanks
Gary

Revision history for this message
dan wendlandt (danwent) wrote :

Yeah, this makes sense. If the built-in python capability can do something, no need to use a third-party lib.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15383

Changed in quantum:
assignee: nobody → Zhongyue Luo (zyluo)
status: New → In Progress
Gary Kotton (garyk)
Changed in quantum:
importance: Undecided → Low
Revision history for this message
yong sheng gong (gongysh) wrote :

Does this mean we remove the _to_xml() method?
     def _to_xml(self, root):
 314 """Convert the xml object to an xml string."""
315 # we use lxml here instead of xml.minidom for performance reasons
316 return etree.tostring(root, encoding='UTF-8', xml_declaration=True)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/15383
Committed: http://github.com/openstack/quantum/commit/3df328144e9a15797ab0dd8c45cf713c32f86d31
Submitter: Jenkins
Branch: master

commit 3df328144e9a15797ab0dd8c45cf713c32f86d31
Author: Zhongyue Luo <email address hidden>
Date: Mon Nov 5 13:35:39 2012 +0800

    Drop lxml dependency

    Fixes bug #1068290

    Removed lxml from tools/pip-requires
    Removed usused method _to_xml() in quantum.wsgi.XMLDictSerializer

    Change-Id: I3410fd8645739abfd853f71efcbb354b58677b18

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.