Creating network is failing in virtual switch mode of the CIsco plugin

Bug #1050545 reported by Sumit Naiksatam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Sumit Naiksatam

Bug Description

Tried creating a network with the conf set to:
model_class=quantum.plugins.cisco.models.virt_phy_sw_v2.VirtualPhysicalSwitchModelV2

and seeing the following exception:

Traceback (most recent call last):
  File "/opt/stack/quantum/quantum/api/v2/resource.py", line 95, in resource
    result = method(request=request, **args)
  File "/opt/stack/quantum/quantum/api/v2/base.py", line 328, in create
    obj = obj_creator(request.context, **kwargs)
  File "/opt/stack/quantum/quantum/plugins/cisco/models/virt_phy_sw_v2.py", line 177, in create_network
    vlan_id = odb.get_vlan(ovs_output[0]['id'])
AttributeError: 'module' object has no attribute 'get_vlan'

This is on account of the recent changes in the OVS module to the get_vlan (and get_vlans) method, which is being invoked here.

Changed in quantum:
status: New → Confirmed
Changed in quantum:
assignee: nobody → Sumit Naiksatam (snaiksat)
Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13059

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/13059
Committed: http://github.com/openstack/quantum/commit/aa5ef1d44f9b5438f0b5b15814c2644690635ee0
Submitter: Jenkins
Branch: master

commit aa5ef1d44f9b5438f0b5b15814c2644690635ee0
Author: Sumit Naiksatam <email address hidden>
Date: Fri Sep 14 17:50:54 2012 -0700

    Fix for failing network operations in Cisco plugin

    Bug #1050545

    This fixes the exceptions occurring in the virtual switch mode of the
    Cisco plugin for create/delete/update network operations. The exceptions
    were occurring on account of the recent changes in the OVS module to the
    get_vlan and get_vlans methods, which were still being invoked here.
    Test configuration has been changed to increase the code coverage to
    catch such issues in the future. All changes are limited to the Cisco
    plugin and related tests.

    Change-Id: Id18473f7a9a2a22217a59b4f8b1541b4918e07e7

Changed in quantum:
status: In Progress → Fix Committed
tags: removed: folsom-rc-potential
Changed in quantum:
milestone: none → folsom-rc2
Changed in quantum:
importance: Undecided → Medium
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13271

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (milestone-proposed)

Reviewed: https://review.openstack.org/13271
Committed: http://github.com/openstack/quantum/commit/ed33a661dfd066c5400e1d7f7e4c99fa5768f172
Submitter: Jenkins
Branch: milestone-proposed

commit ed33a661dfd066c5400e1d7f7e4c99fa5768f172
Author: Sumit Naiksatam <email address hidden>
Date: Fri Sep 14 17:50:54 2012 -0700

    Fix for failing network operations in Cisco plugin

    Bug #1050545

    This fixes the exceptions occurring in the virtual switch mode of the
    Cisco plugin for create/delete/update network operations. The exceptions
    were occurring on account of the recent changes in the OVS module to the
    get_vlan and get_vlans methods, which were still being invoked here.
    Test configuration has been changed to increase the code coverage to
    catch such issues in the future. All changes are limited to the Cisco
    plugin and related tests.

    Change-Id: Id18473f7a9a2a22217a59b4f8b1541b4918e07e7

Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.