[VPNaaS] peer_id validation does not allows formats other than IP address

Bug #1261127 reported by Rami Vaknin on 2013-12-15
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Neutron VPNaaS dashboard
Medium
Cao Xuan Hoang

Bug Description

Version
=======
Havana on rhel

Description
===========

The "Peer router identity for authentication (Peer ID)" box in the "Add IPSec Site Connection" dialog fails validation when non-ip address is inserted although the help balloon states that other values are also possible:

"Peer router identity for authentication. Can be IPv4/IPv6 address, e-mail, key ID, or FQDN"

The validation error message: "Incorrect format for IP address".

Rami Vaknin (rvaknin) wrote :
Akihiro Motoki (amotoki) wrote :

How can I see x-xcf format data?

tags: added: neutron vpnaas
summary: - [Horizon] [VPNaaS] The vpn site connection dialog's "Peer Router
- Identity" text box validation contradicts the box's help balloon
+ [VPNaaS] peer_id validation does not allows formats other than IP
+ address
Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
Rami Vaknin (rvaknin) wrote :

Ooops, I expected gimp to save it in a computer-readable format :-)

Changed in horizon:
assignee: nobody → Leandro Ignacio Costantino (leandro-i-costantino)

I am wondering if we should add a new field like DomainIPField that validate a FDQN using a regex and ip address or we should just set it up as a CharField without restriction.
Any idea?

Akihiro Motoki (amotoki) on 2014-04-02
tags: removed: vpnaas
Tobias (tobik) wrote :

This bug also effects the field "Peer gateway public IPv4/IPv6 Address or FQDN". This field needs another validation (only IP or FQDN - Peer ID needs FQDN/email/IP/key id)

I tried to add a VPN connection with neutron CLI, but there is another bug: https://bugs.launchpad.net/bugs/1405413
Neutron API has validation for correct input, so it should be sufficient to set up both fields as CharField.

Is there anyone who will work on this bug? I would like to do so, but I am very new to python :-)

Akihiro Motoki (amotoki) on 2017-07-25
affects: horizon → neutron-vpnaas-dashboard
Cao Xuan Hoang (hoangcx) wrote :
Changed in neutron-vpnaas-dashboard:
status: Confirmed → In Progress
assignee: Leandro Ignacio Costantino (leandro-i-costantino) → Cao Xuan Hoang (hoangcx)

Reviewed: https://review.openstack.org/518213
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas-dashboard/commit/?id=9ba0382e8dab271d3f91f3b011432cad9997f38f
Submitter: Zuul
Branch: master

commit 9ba0382e8dab271d3f91f3b011432cad9997f38f
Author: Cao Xuan Hoang <email address hidden>
Date: Tue Nov 7 10:40:54 2017 +0700

    Allow peer_id and peer_address input formats other than IP address

    This patch add support the attributes of IPsec connection to be
    able get more formats like FQDN other than IP format as bug report

    Change-Id: I32f20f7cb4407f32978e6ae2bd7b93ea54ce784e
    Closes-bug: #1261127

Changed in neutron-vpnaas-dashboard:
status: In Progress → Fix Released

This issue was fixed in the openstack/neutron-vpnaas-dashboard 1.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers