quark UT warnings part 2

Bug #1604970 reported by alexander medvedev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
quark
Fix Released
Low
alexander medvedev

Bug Description

The following type of Warnings have been addressed:

quark/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/sql/default_comparator.py:153:
SAWarning: The IN-predicate on "quark_routes.subnet_id" was invoked with an empty sequence. This results in a contradiction, which nonetheless can be expensive to evaluate. Consider alternative strategies for improved performance.

and

quark/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/orm/unitofwork.py:235: SAWarning: Object of type <DNSNameserver> not in session, add operation along 'Subnet.dns_nameservers' will not proceed

Changed in neutron-quark:
importance: Undecided → Low
status: New → In Progress
assignee: nobody → alexander medvedev (xroot)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quark (master)

Fix proposed to branch: master
Review: https://review.openstack.org/345056

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quark (master)

Reviewed: https://review.openstack.org/345056
Committed: https://git.openstack.org/cgit/openstack/quark/commit/?id=be9f815458fe3af4701b00dcce66a87fe7b97a6b
Submitter: Jenkins
Branch: master

commit be9f815458fe3af4701b00dcce66a87fe7b97a6b
Author: Alexander Medvedev <email address hidden>
Date: Wed Jul 20 16:19:28 2016 -0500

    Fixes for quark UT warnings

    Silenced a few more warnings from UTs.
    Many subnet create_ and update_ methods add new objects to the session.
    Unit tests, however, mock those methods frequently.
    Hence, the objects are not added to the session, which results in multiple warnings.
    Since, we test the logic and don't care about the actual data written to
    a database, we can also mock the session commit method to avoid warnings.

    Change-Id: I6c129e801f25876b03e28c863328d3ad391034ad
    Closes-Bug: #1604970
    JIRA:NCP-1835

Changed in neutron-quark:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.