Some tests use assertEqual(observed, expected) , the argument order is wrong

[Clint Byrum]

The test cases will produce a confusing error message if the tests ever fail, so this is worth fixing.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/61457

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/64039

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/64415

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/64415
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=240fec9eef800a53aec890ce9ba14b4d07f136d5
Submitter: Jenkins
Branch: master

commit 240fec9eef800a53aec890ce9ba14b4d07f136d5
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Dec 30 11:15:54 2013 +0200

    Fix order of arguments in assertEqual (patch 2/2)

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch includes the other half of the files touched by these changes
    (starting from test_n* plus contrib code) to ease the review.

    Change-Id: I870386871581980abd796304dd91be0c662cb73e
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/61457
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=499b7cccac96e134941dc1e6cd84afe41302fce5
Submitter: Jenkins
Branch: master

commit 499b7cccac96e134941dc1e6cd84afe41302fce5
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Dec 11 17:15:54 2013 +0200

    Fix order of arguments in assertEqual (patch 1/2)

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch includes roughly half of the files touched by these changes
    (up to and including test_m* sans contrib code) to ease the review.

    Partial-Bug: #1259292

    Change-Id: I44bff827c7c50726d48aa649b7685712a233ee62

[Andrew Lazarev (alazarev)]

Could you point on doc that says that correct order of parameters is "expected, observed"? This is true for java junit. I was trying to find the same doc for testtools, but didn't success. Moreover official doc for python unittest (http://docs.python.org/2/library/unittest.html) says the opposite (yes, it is not testtools, but anyway).

[Steve Baker (steve-stevebaker)]

Look at the message that testtools builds for assertEquals fails.

[Kiyohiro Adachi (adachi)]

In 'assertEqual(expected, observed)', the string length of the sum of the results of repr(expected) and repr(observed) is greater than 70, then, MismatchError message is changed. Depending on the length of repr(observed), this condition is satisfied.

https://github.com/testing-cabal/testtools/blob/master/testtools/matchers/_basic.py#L77

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75357

[John Griffith (john-griffith)]

I don't see much value in this and honestly it seems rather silly to go through the effort. It happens that testtools does in fact use the ordering you prefer in their examples, however many other frameworks document using the exact opposite. In reality I don't see what it really matters or what the benefit is.

I don't speak for other projects but from Cinder's perspective this is not something I would want to see proposed for this stage of the release. If you want to go through and change this when Juno opens up and propose for Cinder at that time I suppose that's fine, but right now I'd rather people didn't spend time reviewing changes like this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76453

[Clint Byrum (clint-fewbar)]

Excerpts from John Griffith's message of 2014-02-25 23:47:08 UTC:
> I don't see much value in this and honestly it seems rather silly to go
> through the effort. It happens that testtools does in fact use the
> ordering you prefer in their examples, however many other frameworks
> document using the exact opposite. In reality I don't see what it
> really matters or what the benefit is.
>
> I don't speak for other projects but from Cinder's perspective this is
> not something I would want to see proposed for this stage of the
> release. If you want to go through and change this when Juno opens up
> and propose for Cinder at that time I suppose that's fine, but right now
> I'd rather people didn't spend time reviewing changes like this.
>

Hi John. The trouble happens when the tests fail, and it tells you the
opposite of reality. This isn't about the examples, it is about the text
of the failure report.

Unit tests are meant to help debug situations where a developer has
misunderstood complex inner workings of things. So if we also tell
them that we observed what they expect in the test, and expect what was
observed and what was also wrong, we are just decreasing the value of
the unit tests.

I agree that early in dev cycles is a better time for low priority issues,
and this is a low priority, but it is not a low value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77562

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/78762

[Ildiko Vancsa (ildiko-vancsa)]

Hi,

This bug has a duplication: https://bugs.launchpad.net/ceilometer/+bug/1277104. There are ongoing activities for both bug reports, some of them are overlapping (Ceilometer and Cinder). It would be good to check these activities and synchronize them.

Best Regards,
Ildiko

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82498

[Ildiko Vancsa (ildiko-vancsa)]

Patch for python-ceilometerclient: https://review.openstack.org/#/c/81154/3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82498
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=e07e9d936665d4c7e58edc30e2746544ce4fa784
Submitter: Jenkins
Branch: master

commit e07e9d936665d4c7e58edc30e2746544ce4fa784
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Mar 24 14:58:47 2014 +0200

    Use correct order of arguments to assertEqual

    The correct order of arguments to assertEqual that is expected by
    testtools is (expected, observed).

    This patch fixes the inverted usage of arguments in some places
    that have cropped up since the last fix of this bug.

    Change-Id: Ifbc5da5cba0c8dcdf5b9c9eb6e6bfb1b1c2b49b0
    Closes-Bug: #1259292

[Sandeep Kedari (sandy86299)]

Working on the following bug

[gordon chung (chungg)]

marking invalid for ceilometer, will track via https://bugs.launchpad.net/ceilometer/+bug/1277104

[OpenStack Infra (hudson-openstack)]

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/75357
Reason: Abandoning change: No update for more than 14 days

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76453
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=f3ec0814971112068e933e343ef7ab8986f438c3
Submitter: Jenkins
Branch: master

commit f3ec0814971112068e933e343ef7ab8986f438c3
Author: KIYOHIRO ADACHI <email address hidden>
Date: Wed Feb 26 15:59:14 2014 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is...

        def assertEqual(self, expected, observed, message=''):
            """Assert that 'expected' is equal to 'observed'.

            :param expected: The expected value.
            :param observed: The observed value.
            :param message: An optional message to include in the error.
            """

    The string length of the sum of the results of repr(expected) and
    repr(observed) is greater than 70, then, MismatchError message is
    changed, as below.

      Ex.:
            raise mismatch_error
        MismatchError: !=:
        reference = '_123456789_123456789_bar'
        actual = '_123456789_123456789_123456789_123456789_123456789'

    Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/77562
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c7d5371b47079a07f32137e82422ded41d501a9f
Submitter: Jenkins
Branch: master

commit c7d5371b47079a07f32137e82422ded41d501a9f
Author: ChenZheng <email address hidden>
Date: Mon Mar 3 18:48:46 2014 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: Iabf6e55146412b57b6a6544f312f9510f762566a
    Partial-Bug: #1259292

[Qiming Teng (tengqim)]

Qiming is screening the heat code base to make sure Heat is not affected by this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138369

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138369
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3d2b7facdab23181b876b2272f587a2400caadc1
Submitter: Jenkins
Branch: master

commit 3d2b7facdab23181b876b2272f587a2400caadc1
Author: tengqm <email address hidden>
Date: Tue Dec 2 21:44:12 2014 +0800

    Make all assertEqual() calls conform to convention

    It is a convention to have assertEqual() assertions invoked with
    'expected value' before 'actual value', or else the debug output may
    become very confusing. This patch fixes about 100 violations in current
    test cases where about 3580 assertEqual calls are made.

    Closes-Bug: 1259292
    Change-Id: I2e0474d9821716baf35a3bbb2952c63a84749dd3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145118

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145133

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145162

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145166

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145173

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145133
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f743605fa3dae8f57003e50fa50c864a89e8c3b2
Submitter: Jenkins
Branch: master

commit f743605fa3dae8f57003e50fa50c864a89e8c3b2
Author: Bharat Kumar Kobagana <email address hidden>
Date: Tue Jan 6 11:14:18 2015 +0530

    Fix argument order in assertEqual: tests/test_glusterfs.py

    The assertEqual in cinder/tests/test_glusterfs.py is using
    incorrect argument order (observed, expected), which causes the
    error message about mismatch to be reversed if the test case fails.
    Change it to (expected, observed).

    Change-Id: Idcd88de9c5e8a096f0ef473e92bff17e6be16814
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/145162
Reason: inactive for a month

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145166
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d813f3f005be6043e615c57f3f7b0a3e0b4d30b3
Submitter: Jenkins
Branch: master

commit d813f3f005be6043e615c57f3f7b0a3e0b4d30b3
Author: Bharat Kumar Kobagana <email address hidden>
Date: Tue Jan 6 14:08:05 2015 +0530

    Fix argument order in assertEqual: tests/test_nfs.py

    The assertEqual in cinder/tests/test_nfs.py is using
    incorrect argument order (observed, expected), which causes the
    error message about mismatch to be reversed if the test case fails.
    Change it to (expected, observed).

    Change-Id: I7fec2e5df91369c3cae2adef3189e8bd86fe4480
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bharat Kumar Kobagana (<email address hidden>) on branch: master
Review: https://review.openstack.org/145173
Reason: As this patch is not necessary as a separate patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157474

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165271

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165347

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165350

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165271
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=cb480679a1f75f558be414f85143c11b2406a31b
Submitter: Jenkins
Branch: master

commit cb480679a1f75f558be414f85143c11b2406a31b
Author: Jacob Bin Wang <email address hidden>
Date: Wed Mar 18 09:29:40 2015 +0800

    Fix order of arguments in assertEqual - Part1

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is:
        def assertEqual(self, expected, observed, message='')
    Changed to use the right order. Also if the order is wrong and
    expected value is None, change it to assertIsNone instead.

    It requires big changes and some tests change frequently.
    So I would do it in series of small CR.
    This part contains all changes except tests of plugins and service.

    Partial-Bug: #1259292

    Change-Id: Iefbb5f4b9efca35f7a2298f9f7f5b9de73fc260f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165347
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=19b25fe29c99e37ba32076b6ea41be04d80e5363
Submitter: Jenkins
Branch: master

commit 19b25fe29c99e37ba32076b6ea41be04d80e5363
Author: Jacob Bin Wang <email address hidden>
Date: Wed Mar 18 18:24:47 2015 +0800

    Fix order of arguments in assertEqual - Part2

    This part contains changes in tests of plugins.

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is:
        def assertEqual(self, expected, observed, message='')

    It requires big changes and some tests change frequently.
    So I would do it in series of small CR.

    Partial-Bug: #1259292

    Change-Id: Ie75c6919c60674a4fea7ae95d74c1068e343f026

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165350
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=2fce61bfafc6bd8b83dbadc23038838f7c8c552d
Submitter: Jenkins
Branch: master

commit 2fce61bfafc6bd8b83dbadc23038838f7c8c552d
Author: Jacob Bin Wang <email address hidden>
Date: Wed Mar 18 18:28:38 2015 +0800

    Fix order of arguments in assertEqual - Part3

    This part contains changes in tests of service.

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is:
        def assertEqual(self, expected, observed, message='')

    It requires big changes and some tests change frequently.
    So I would do it in series of small CR, and this is the last one.

    Closes-Bug: #1259292

    Change-Id: I20c215da18775e9a4d257462446f4adbecd26056

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157474
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=98e405a40ffd91a70e27248500497a76fad34fbb
Submitter: Jenkins
Branch: master

commit 98e405a40ffd91a70e27248500497a76fad34fbb
Author: Sai Kiran <email address hidden>
Date: Thu Feb 19 23:12:54 2015 +0530

    Fix argument order in assertEqual: tests/test_service.py

    The assertEqual in cinder/tests/test_service.py is using
    incorrect argument order (observed, expected), which causes the
    error message about mismatch to be reversed if the test case fails.
    Change it to (expected, observed).

    Change-Id: I30fc2ff65e0ebdbff5fca24cbef024999ad0a64e
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/145118
Reason: No activity for over a month.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/206296

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/206296
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4982812364ec600bbff55ed2b7ffd7c31737ca3b
Submitter: Jenkins
Branch: master

commit 4982812364ec600bbff55ed2b7ffd7c31737ca3b
Author: appsdesh <email address hidden>
Date: Mon Jul 27 21:23:36 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch does not cover v1 api tests and vendor unit tets.

    Change-Id: Icb0636143cfc48d5189bcb0faa6e643f68c32f5e
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/210160

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/210160
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3c236141c90424650fe4eadbdf053a1bad277467
Submitter: Jenkins
Branch: master

commit 3c236141c90424650fe4eadbdf053a1bad277467
Author: Skyler Berg <email address hidden>
Date: Tue Aug 4 14:44:58 2015 -0700

    Fix argument order for assertEqual in tests

    Some tests incorrectly use the order assertEqual(observed, expected)
    instead of the correct order, assertEqual(expected, observed). This
    patch corrects this issue.

    Change-Id: I4683b80451d3e4576443c4472a01460b24633d04
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/213443

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218809

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218811

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218813

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218817

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219265

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219266

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219267

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219269

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219270

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218811
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=eb8d4f953c5a922111ff5a6a37bb48ac24fdab29
Submitter: Jenkins
Branch: master

commit eb8d4f953c5a922111ff5a6a37bb48ac24fdab29
Author: PranaliDeore <email address hidden>
Date: Mon Aug 31 00:33:33 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: If41740753873c58c640e685b92f1968420ce1408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218809
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2e03de6b0d3c4415b7dcad44118f588b09e518f1
Submitter: Jenkins
Branch: master

commit 2e03de6b0d3c4415b7dcad44118f588b09e518f1
Author: PranaliDeore <email address hidden>
Date: Sun Aug 30 23:46:45 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: I3d81fbc0a9634ae66df5dc61f14539074c18e492

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218813
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=399b755630672373f370adc0f1df3123c30e230e
Submitter: Jenkins
Branch: master

commit 399b755630672373f370adc0f1df3123c30e230e
Author: PranaliDeore <email address hidden>
Date: Mon Aug 31 00:00:50 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: If724fbfc0b7e04f4b79e42aa6b9f00b54210a506

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220134

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220142

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220143

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220466

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221228

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221271

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220143
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3622a20f2d87a807873e4c1821bad7872784067e
Submitter: Jenkins
Branch: master

commit 3622a20f2d87a807873e4c1821bad7872784067e
Author: Rajesh Tailor <email address hidden>
Date: Wed Sep 2 03:57:13 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: Ie57021baffb208babdfa42c72e4d5b4e8c2b1c18

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221609

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221663

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221739

[Rajesh Tailor (rajesh-tailor)]

Hi,

For nova project, I will do changes for assertNotEqual as well with assertEqual method wherever argument order is wrong.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221739
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7db5128a86b910979814cb966fb8e9a7984098e5
Submitter: Jenkins
Branch: master

commit 7db5128a86b910979814cb966fb8e9a7984098e5
Author: Rajesh Tailor <email address hidden>
Date: Tue Sep 8 00:29:32 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: Ie5390a5d583c56bf6392c315ba665274a4b4eaab

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/223053

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218817
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=16db827eaa77fe1a462f8d45c4dda97806de9e73
Submitter: Jenkins
Branch: master

commit 16db827eaa77fe1a462f8d45c4dda97806de9e73
Author: PranaliDeore <email address hidden>
Date: Mon Aug 31 00:15:47 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: I30e7c4346844ec0eba50c50ca327ca1966600e7d

[Assaf Muller (amuller)]

Removing Neutron from affected projects, this is not worth the effort.

[Rajesh Tailor (rajesh-tailor)]

Hi,

There are some occurrences in keystone project where wrong argument order is passed in assertDictEqual method.

Should we report separate bug for this issue or can we submit those changes against same bug ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226677

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221271
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=830010b443716496fca838b81fde7f3717a6cffd
Submitter: Jenkins
Branch: master

commit 830010b443716496fca838b81fde7f3717a6cffd
Author: Rajesh Tailor <email address hidden>
Date: Fri Sep 4 02:37:27 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Replaced assertEqual with assertTrue/assertFalse wherever required.

    Partial-Bug: #1259292
    Change-Id: If0a1f3850d92d011aae32ae34e8c8664f2ee4313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220142
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9da8f861ce0e94582d945d7caaa535521b687987
Submitter: Jenkins
Branch: master

commit 9da8f861ce0e94582d945d7caaa535521b687987
Author: Rajesh Tailor <email address hidden>
Date: Wed Sep 2 01:53:57 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292
    Change-Id: I98dd592b9f67be0fcfd26cc9a2b670f9a270cea0

[Ken'ichi Ohmichi (oomichi)]

Is someone working for creating pep8 check for this?

There is a lot of this kind of patches in Nova, and I'd like to avoid reviewing this kind of patches in the future.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/227650

[Ken'ichi Ohmichi (oomichi)]

https://review.openstack.org/#/c/227650/ adds one of assertEqual order check.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228388

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228402

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/223053
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ee9ecfca16a0f9e65ff0754796078aed515cb6b1
Submitter: Jenkins
Branch: master

commit ee9ecfca16a0f9e65ff0754796078aed515cb6b1
Author: Rajesh Tailor <email address hidden>
Date: Thu Sep 10 03:54:17 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    At some places, corrected argument order for assertNotEqual method as well
    and replaced assertEqual with assertTrue/assertFalse wherever required.

    Closes-Bug: #1259292
    Change-Id: I6fff8a3eedd053d0de8e261245a32f9a9fdab213

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228415

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228420

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228431

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226677
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=3f74823fb85da32e8e1b727a5cbb1b2358b7eb55
Submitter: Jenkins
Branch: master

commit 3f74823fb85da32e8e1b727a5cbb1b2358b7eb55
Author: Rajesh Tailor <email address hidden>
Date: Thu Sep 10 23:30:35 2015 -0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    At some places, corrected argument order for assertNotEqual method as well.

    Change-Id: I6d63e77620b8dd9d6415424783b99a7e2e381a22
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228402
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=f6f40621e917fb2c5bfc31ccc636f369798ca18a
Submitter: Jenkins
Branch: master

commit f6f40621e917fb2c5bfc31ccc636f369798ca18a
Author: MD NADEEM <email address hidden>
Date: Mon Sep 28 20:04:52 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/functional/wsgi/v1 and base.py file.
    Partial-Bug: #1259292

    Change-Id: Ic0c1d46869d34e4eb4604e5ce6a62edd9b2a4824

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228705

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228721

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228725

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228726

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228729

[Reedip (reedip-banerjee-deactivatedaccount)]

Fix proposed for neutron-fwaas:
https://review.openstack.org/228730

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228735

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228751

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228763

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228770

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228776

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228811

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228812

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228820

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228826

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228841

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228874

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228874
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=38513f7dc5e73b3cbe520eba336f9088a7850160
Submitter: Jenkins
Branch: master

commit 38513f7dc5e73b3cbe520eba336f9088a7850160
Author: Tetiana Lashchova <email address hidden>
Date: Tue Sep 29 15:20:16 2015 +0300

    Fix order of arguments in assertEqual

    Some tests used incorrect order of arguments in assertEqual.
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I210ce20cb9427799219e8aedb9ee3282dea53d3f
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228811
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=c6d74e21de7a0dfd8d77bd253fc0db85a1edf79b
Submitter: Jenkins
Branch: master

commit c6d74e21de7a0dfd8d77bd253fc0db85a1edf79b
Author: Pradeep Kumar Singh <email address hidden>
Date: Tue Sep 29 14:58:02 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: I1f5725e48f6de14379e77fe6edbf88d0a8b706fc
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228812
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=4fd6f9c6c3667b88cb19fdb8701452a24f94aaea
Submitter: Jenkins
Branch: master

commit 4fd6f9c6c3667b88cb19fdb8701452a24f94aaea
Author: Pradeep Kumar Singh <email address hidden>
Date: Tue Sep 29 15:12:09 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: I6843053fd6178047ee0d9dadf35d5644de3b679e
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229241

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229245

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229249

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229256

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229265

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229272

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229285

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229327

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229332

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228388
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=199dca0aeaf0d747778d19e6a273144923f6edd6
Submitter: Jenkins
Branch: master

commit 199dca0aeaf0d747778d19e6a273144923f6edd6
Author: hardik <email address hidden>
Date: Thu Sep 24 16:43:48 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I5ac8602b47a747e77dc8afd579d4e280b3ed894f
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229360

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229366

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/229421

[David Stanek (dstanek)]

There may be other places where this is still an issue, but I don't think it's worth the effort to find them.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228770
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3a1e193e325f7617784f635190bf83abbbb0cf4e
Submitter: Jenkins
Branch: master

commit 3a1e193e325f7617784f635190bf83abbbb0cf4e
Author: Yusuke Hayashi <email address hidden>
Date: Tue Sep 29 02:17:44 2015 +0900

    Fix order of arguments in assertEqual

    Fix incorrect order assertEqual(observed, expected) as below.
      assertEqual(observed, expected) => assertEqual(expected, observed)

    Target of this patch:
      manila/tests/test_xxx.py

    Change-Id: Idcaf6721ce4d90b34fe834dc0f26763fd0035bd8
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229249
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=aceb80756636d5f2a6e0c6b98939e101534e40bf
Submitter: Jenkins
Branch: master

commit aceb80756636d5f2a6e0c6b98939e101534e40bf
Author: Pradeep Kumar Singh <email address hidden>
Date: Wed Sep 30 11:16:37 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: Ia0f89c74551931044d7a7da27cf2335d3f6c3a6e
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229421
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7c71ecb91dfccf317e6ecbae3381fe6606fd1a2b
Submitter: Jenkins
Branch: master

commit 7c71ecb91dfccf317e6ecbae3381fe6606fd1a2b
Author: Rajesh Tailor <email address hidden>
Date: Thu Sep 24 06:27:50 2015 -0700

    Fix order of arguments in assertDictEqual

    Some tests used incorrect order assertDictEqual(observed, expected).

    The correct order expected by testtools is
    assertDictEqual(expected, observed).

    Change-Id: I4960a56755fb5da985da7a362dd94c3b57a41875
    Related-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228820
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=b6e00bb7b495066d9a89695f3622bd716ac889b8
Submitter: Jenkins
Branch: master

commit b6e00bb7b495066d9a89695f3622bd716ac889b8
Author: Pradeep Kumar Singh <email address hidden>
Date: Tue Sep 29 15:48:44 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: I7e311d3d3e440478fd242aa74370d09f71ceb7c4
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229241
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=220b097c6b8d4e24836482f2ca84ce48d61a0bd3
Submitter: Jenkins
Branch: master

commit 220b097c6b8d4e24836482f2ca84ce48d61a0bd3
Author: Pradeep Kumar Singh <email address hidden>
Date: Wed Sep 30 10:21:31 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: I04ed66a896b73e2feaaf8d85db48883eaf2f50c1
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229713

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229360
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=a581788250e0707a634d3ff595ca00a11c1ce6af
Submitter: Jenkins
Branch: master

commit a581788250e0707a634d3ff595ca00a11c1ce6af
Author: hardik <email address hidden>
Date: Sun Sep 13 10:04:01 2015 +0530

    Fix order of arguments in assertEqual

    Fixed for mistral/tests/functional/engine/actions/v2/test_openstack_actions.py

    Change-Id: Ia3fa587d7d2acb0d6d7f7ee310e562d10882132f
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229797

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/229806

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229285
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=4a5e16014cc251978bdf9d368e52f6165cd866cc
Submitter: Jenkins
Branch: master

commit 4a5e16014cc251978bdf9d368e52f6165cd866cc
Author: MD NADEEM <email address hidden>
Date: Wed Sep 30 17:12:47 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in some file of the module
    zaqar/tests/unit/transport/wsgi/v2_0/ .
    Partial-Bug: #1259292

    Change-Id: Ic9f7c369f69d5b92aab1b26af5105e78ecf03bf9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228729
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=b38177360feac5677f3417396da4b82822939c0a
Submitter: Jenkins
Branch: master

commit b38177360feac5677f3417396da4b82822939c0a
Author: Anusha Ramineni <email address hidden>
Date: Tue Sep 29 10:41:22 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    Because of the same test cases produce a confusing error message
    if the tests ever fail.

    This patch handles only for API tests

    Change-Id: I8d9897808ab488c445496b30753602ada6b40c77
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229713
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=42ecc84a2ce8d72608ba519624661d37c02b554e
Submitter: Jenkins
Branch: master

commit 42ecc84a2ce8d72608ba519624661d37c02b554e
Author: Yusuke Hayashi <email address hidden>
Date: Tue Sep 29 19:56:49 2015 +0900

    Fix order of arguments in assertEqual

    Fix incorrect order assertEqual(observed, expected) as below.
      assertEqual(observed, expected) => assertEqual(expected, observed)

    Target of this patch:
      manila/tests/api/*

    Note:
    I also fix following asserts aruond above fixed parts.
      assertEqual(xx, True), assertEqual(True, xx) => assertTrue(xx)

    As for assertFalse,
    I do not convert assertEqual(xx, False) to assertFalse(xx)
    because assertFalse(None) does not raise exception.

    Change-Id: I8131946efef654235b5e32344b3f5e42ab3d3ced
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228725
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=c10f06e2e84644c800a00c1a7ccf456f3ded6f08
Submitter: Jenkins
Branch: master

commit c10f06e2e84644c800a00c1a7ccf456f3ded6f08
Author: hardik <email address hidden>
Date: Fri Sep 25 09:51:00 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I72e1d8a6b52fa6dbb85b57438aef92ad13735880
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/221663
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/221304
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/222093
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/220466
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/221228
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/220134
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Garbutt (<email address hidden>) on branch: master
Review: https://review.openstack.org/221609
Reason: Marking this bug as invalid for Nova, basically because:
* there is very little gain in doing this (slightly cosmetic issue in error message)
* its a lot of code churn and review effort
* unable to find automated test to make sure it does not regress, meaning we have to keep fixing it for ever

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ken'ichi Ohmichi (<email address hidden>) on branch: master
Review: https://review.openstack.org/227650
Reason: I can agree with that, because I also wasn't sure that this is not right direction at the time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/231285

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231285
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d3e50fd70ffb4a6476f7bad201d1c2d5ab702328
Submitter: Jenkins
Branch: master

commit d3e50fd70ffb4a6476f7bad201d1c2d5ab702328
Author: Yusuke Hayashi <email address hidden>
Date: Sat Oct 3 10:05:41 2015 +0900

    Fix order of arguments in assertEqual

    Fix incorrect order assertEqual(observed, expected) as below.
      assertEqual(observed, expected) => assertEqual(expected, observed)

    Target of this patch:
      manila/tests/cmd/*
      manila/tests/compute/*
      manila/db/*
      manila/network/*

    Change-Id: I6dd4f8057facc68e716b57229cbc4096af8bb152
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/231869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231869
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=8ce1530e21862b934faae9ffabf0ad879df0aae3
Submitter: Jenkins
Branch: master

commit 8ce1530e21862b934faae9ffabf0ad879df0aae3
Author: Yusuke Hayashi <email address hidden>
Date: Sun Oct 4 03:43:17 2015 +0900

    Fix order of arguments in assertEqual

    Fix incorrect order assertEqual(observed, expected) as below.
      assertEqual(observed, expected) => assertEqual(expected, observed)

    Target of this patch:
      manila/tests/share/*

    Note:
    I also fix following asserts around above fixed parts.
      assertEqual(xx, True), assertEqual(True, xx) => assertTrue(xx)

    As for assertFalse,
    I do not convert assertEqual(xx, False) to assertFalse(xx)
    because assertFalse(None) does not raise exception.

    Change-Id: I56688105ab3b77e4f71bde472763a9c02c43664b
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229272
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=ac356d40bcddc87a42a2d4d28150d82ea5f454fb
Submitter: Jenkins
Branch: master

commit ac356d40bcddc87a42a2d4d28150d82ea5f454fb
Author: MD NADEEM <email address hidden>
Date: Wed Sep 30 16:31:57 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in some file of the module
    zaqar/tests/unit/transport/wsgi/v2_0/ .
    Partial-Bug: #1259292

    Change-Id: Ie71a32d1319eefd22b31ea95cc926c3e8cf11e09

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229265
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=9a24a63d546d5a7d8b3d9982462ee5e2fe8e9764
Submitter: Jenkins
Branch: master

commit 9a24a63d546d5a7d8b3d9982462ee5e2fe8e9764
Author: MD NADEEM <email address hidden>
Date: Wed Sep 30 15:57:01 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in some file of the module
    zaqar/tests/unit/transport/wsgi/v1_1/ .
    Partial-Bug: #1259292

    Change-Id: I6ce124a83fdf9978996e7304e2e15bd2de32e53a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229256
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=5416303d95f39a22375bf90fdcf9b6aff5ec20e0
Submitter: Jenkins
Branch: master

commit 5416303d95f39a22375bf90fdcf9b6aff5ec20e0
Author: MD NADEEM <email address hidden>
Date: Wed Sep 30 15:14:55 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in some file of the module
    zaqar/tests/unit/transport/wsgi/v1_1/ .
    Partial-Bug: #1259292

    Change-Id: Idf76e68ae72e8599999f53bdffdb71d85b8852cb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229245
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=6f4c8beaccd807935e4dae4657b649867ed5d32d
Submitter: Jenkins
Branch: master

commit 6f4c8beaccd807935e4dae4657b649867ed5d32d
Author: MD NADEEM <email address hidden>
Date: Wed Sep 30 14:40:59 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/unit/transport/wsgi/v1/ .
    Partial-Bug: #1259292

    Change-Id: I4e2252efd810ab658c1d3ad03081c3807daebfcb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228763
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=fda1a263869a36114ebaf814a553a15827290464
Submitter: Jenkins
Branch: master

commit fda1a263869a36114ebaf814a553a15827290464
Author: MD NADEEM <email address hidden>
Date: Tue Sep 29 16:40:05 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/unit/transport/websocket .
    Partial-Bug: #1259292

    Change-Id: Id480e0fe6504f6511707e6fc2edfbb5e6fc219f4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228776
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=d40e941755ca89a4d33be90b699f413f2f9e3ad5
Submitter: Jenkins
Branch: master

commit d40e941755ca89a4d33be90b699f413f2f9e3ad5
Author: MD NADEEM <email address hidden>
Date: Tue Sep 29 17:15:04 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/unit/transport/wsgi/ .
    Partial-Bug: #1259292

    Change-Id: I883d9b34f8398cc830f8161a680364c9e0e0fa09

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228751
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=6c89270d0ee0b6fe60df16d6859ac3cd9510bfb2
Submitter: Jenkins
Branch: master

commit 6c89270d0ee0b6fe60df16d6859ac3cd9510bfb2
Author: MD NADEEM <email address hidden>
Date: Tue Sep 29 16:06:21 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the modules zaqar/tests/unit/storage/
    and zaqar/tests/unit/notification/ modules.
    Partial-Bug: #1259292

    Change-Id: Iac8987782d6a21a28a0503ea7cd4ec85622f7996

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228726
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=3a1019daccaf7afaa03457fdc3d99a84581e8591
Submitter: Jenkins
Branch: master

commit 3a1019daccaf7afaa03457fdc3d99a84581e8591
Author: MD NADEEM <email address hidden>
Date: Tue Sep 29 14:07:35 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/unit/common/storage/ .
    Patches is generated module wise to ease the review process.
    Partial-Bug: #1259292

    Change-Id: I40a6349dc008ea0cb4c94714f01418acdf75e3b8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228705
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=246bc00e9d68f9597c0f725de437ba2ba992bc54
Submitter: Jenkins
Branch: master

commit 246bc00e9d68f9597c0f725de437ba2ba992bc54
Author: MD NADEEM <email address hidden>
Date: Tue Sep 29 12:16:20 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/functional/wsgi/v1_1/.
    Partial-Bug: #1259292

    Change-Id: I192084e8556059efda9c34b802b86435fa3c1869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228721
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=aa82943d96352d3f21f0bdeb217d74162955a896
Submitter: Jenkins
Branch: master

commit aa82943d96352d3f21f0bdeb217d74162955a896
Author: MD NADEEM <email address hidden>
Date: Tue Sep 29 13:42:58 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module zaqar/tests/unit/common/ .
    Partial-Bug: #1259292

    Change-Id: Ia2272618593eee23d335efb2efce77f3556f6fca

[Yusuke Hayashi (hayashi-yusuke)]

I set ths status of manila project to FixCommited
because I fixed in following patch.
https://review.openstack.org/232333
#Sorry, I set other bug number in above patch...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233332

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233342

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233332
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=cfec8634583f14dc286410b015fbd183163f3c1f
Submitter: Jenkins
Branch: master

commit cfec8634583f14dc286410b015fbd183163f3c1f
Author: lei-zhang-99cloud <[e-mail]>
Date: Sat Oct 10 11:27:29 2015 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    This patch fix the issue in the module magnum/tests/functional/.

    Change-Id: Ic5151d6052780180179189cf47cc41f9215e2af5
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233356

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233364

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233342
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=c2cc0332602f8b069f7a8214e6369800ec3fa4c4
Submitter: Jenkins
Branch: master

commit c2cc0332602f8b069f7a8214e6369800ec3fa4c4
Author: lei-zhang-99cloud <[e-mail]>
Date: Sat Oct 10 14:23:04 2015 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    This patch fix the issue in the module magnum/tests/unit/api/.

    Change-Id: I947346f36212ad518b68ac31ef83cf594e125153
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233356
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=7fda571402c05eb832702a77735efcd403d507f2
Submitter: Jenkins
Branch: master

commit 7fda571402c05eb832702a77735efcd403d507f2
Author: lei-zhang-99cloud <[e-mail]>
Date: Sat Oct 10 17:12:38 2015 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    This patch fix the issue in the module magnum/tests/unit/conductor/.

    Change-Id: Ib8ead5a00b8095892341e08b1662b053ac1ec36b
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233345
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=cb46cfafa8425553474baf5d09ca4a7a05deeef1
Submitter: Jenkins
Branch: master

commit cb46cfafa8425553474baf5d09ca4a7a05deeef1
Author: lei-zhang-99cloud <[e-mail]>
Date: Sat Oct 10 14:41:52 2015 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    This patch fix the issue in the module magnum/tests/unit/common/.

    Change-Id: Ib92006145171d265b836e0fc9951583414d83952
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233364
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=0961c864aecc34ebfb37dc613f08084f46b0a4a3
Submitter: Jenkins
Branch: master

commit 0961c864aecc34ebfb37dc613f08084f46b0a4a3
Author: lei-zhang-99cloud <[e-mail]>
Date: Sat Oct 10 18:41:59 2015 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the modules magnum/tests/unit/db/. 、
    magnum/tests/unit/object/. and magnum/tests/unit/service/. modules.

    Change-Id: If193d8904ac4e4637e3ad97c8050696661cd6112
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228415
Committed: https://git.openstack.org/cgit/openstack/python-zaqarclient/commit/?id=5b35d7626a81a6e0cb85c176a8824ac4a2ae162d
Submitter: Jenkins
Branch: master

commit 5b35d7626a81a6e0cb85c176a8824ac4a2ae162d
Author: MD NADEEM <email address hidden>
Date: Mon Sep 28 20:39:36 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module /tests/unit/queues/v1 of zaqarclient.
    Partial-Bug: #1259292

    Change-Id: Ia5969d904012647f29b5047e37cad9ce3a77a489

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228431
Committed: https://git.openstack.org/cgit/openstack/python-zaqarclient/commit/?id=eb104b2c6bd071d2df123c9041735740b5e56feb
Submitter: Jenkins
Branch: master

commit eb104b2c6bd071d2df123c9041735740b5e56feb
Author: MD NADEEM <email address hidden>
Date: Mon Sep 28 21:17:44 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in the module /tests/queues/ of zaqarclient.
    The review is generated part-wise to ease review process.
    Partial-Bug: #1259292

    Change-Id: I405ca85d497361b41ada5eab567dd9735e787c32

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228420
Committed: https://git.openstack.org/cgit/openstack/python-zaqarclient/commit/?id=7adf35effcbff4ce9f12fe2418a10df7e73fe4c1
Submitter: Jenkins
Branch: master

commit 7adf35effcbff4ce9f12fe2418a10df7e73fe4c1
Author: MD NADEEM <email address hidden>
Date: Mon Sep 28 20:49:53 2015 +0900

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    This patch fix the issue in some test file of zaqarclient.
    The review is generated part-wise to ease review process.
    Partial-Bug: #1259292

    Change-Id: I3f51e3a400d1c408e6c65b9ed503efd414b3d5ed

[OpenStack Infra (hudson-openstack)]

Change abandoned by hardik (<email address hidden>) on branch: master
Review: https://review.openstack.org/229327
Reason: This fix cannot work in some scenarios.

[OpenStack Infra (hudson-openstack)]

Change abandoned by hardik (<email address hidden>) on branch: master
Review: https://review.openstack.org/229366
Reason: Fix cannot cover complete scenarios.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233952

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233957

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233952
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=4e3bf1a25499dd71ea18773944c60361359a3f6f
Submitter: Jenkins
Branch: stable/liberty

commit 4e3bf1a25499dd71ea18773944c60361359a3f6f
Author: hardik <email address hidden>
Date: Sun Sep 13 10:04:01 2015 +0530

    Fix order of arguments in assertEqual

    Fixed for mistral/tests/functional/engine/actions/v2/test_openstack_actions.py

    Change-Id: Ia3fa587d7d2acb0d6d7f7ee310e562d10882132f
    Partial-Bug: #1259292
    (cherry picked from commit a581788250e0707a634d3ff595ca00a11c1ce6af)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233957
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=9215073f29632a7a74917d28354982141134ad3a
Submitter: Jenkins
Branch: stable/liberty

commit 9215073f29632a7a74917d28354982141134ad3a
Author: hardik <email address hidden>
Date: Thu Sep 24 16:43:48 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I5ac8602b47a747e77dc8afd579d4e280b3ed894f
    Partial-Bug: #1259292
    (cherry picked from commit 199dca0aeaf0d747778d19e6a273144923f6edd6)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/234014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228735
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=1f01af47e03b11f5a11a0591cdb1103e2951fe05
Submitter: Jenkins
Branch: master

commit 1f01af47e03b11f5a11a0591cdb1103e2951fe05
Author: sonu.kumar <email address hidden>
Date: Tue Sep 29 11:33:16 2015 +0530

    Fix order of argument in assertEqual

    Some tests used incorrect argument order in
    assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed)

    Change-Id: I73b331a1c75aa9e136c64ebaf363e7a2ef6a3ebc
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234306

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234306
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=f666137b5eaa77871968185265bd9f7a5f8ac5ff
Submitter: Jenkins
Branch: stable/liberty

commit f666137b5eaa77871968185265bd9f7a5f8ac5ff
Author: hardik <email address hidden>
Date: Fri Sep 25 09:51:00 2015 +0530

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I72e1d8a6b52fa6dbb85b57438aef92ad13735880
    Partial-Bug: #1259292
    (cherry picked from commit c10f06e2e84644c800a00c1a7ccf456f3ded6f08)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229332
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=a3e78d76fe9cc395a3c4d82cfc600fcb4f65fe68
Submitter: Jenkins
Branch: master

commit a3e78d76fe9cc395a3c4d82cfc600fcb4f65fe68
Author: Anusha Ramineni <email address hidden>
Date: Wed Sep 30 11:08:02 2015 +0530

    Fix some more discrepancies in assertEqual

    This patch is follow up on https://review.openstack.org/#/c/228729/

    Partial-Bug:#1259292
    Change-Id: I2870234c989541531964dee7123f02cee1782ada

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234014
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=c0216f1aa62c15f36b0ff7a15dbc92b6ecb58785
Submitter: Jenkins
Branch: master

commit c0216f1aa62c15f36b0ff7a15dbc92b6ecb58785
Author: hardik <email address hidden>
Date: Sat Sep 26 06:37:18 2015 +0530

    Fix order of arguments in assertEqual

    Corrected for /tests/unit/v2/test_cli_workbooks.py and
    /tests/unit/v2/test_cli_workflows.py.

    Change-Id: Ia3532851d466d7508fd4130a3c06278c0b3c36e1
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228826
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=2fed891b5a762bf6c0a353ceb982c36f87b62025
Submitter: Jenkins
Branch: master

commit 2fed891b5a762bf6c0a353ceb982c36f87b62025
Author: sonu.kumar <email address hidden>
Date: Tue Sep 29 15:52:15 2015 +0530

    Fix order of argument in assertEqual

    Some tests in test_zone.py used incorrect argument
    order in assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I60e491f5629fd6dccd25c24bfb158d3c2b0145f1
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229797
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=e7940e5f0e5612ce5499e4c13b8dda1801528dc0
Submitter: Jenkins
Branch: master

commit e7940e5f0e5612ce5499e4c13b8dda1801528dc0
Author: sonu.kumar <email address hidden>
Date: Thu Oct 1 15:08:02 2015 +0530

    Fix order of argument in assertEqual

    Some tests in test_domain.py used incorrect argument
    order in assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I1c3db17fce9278389622492289bbd253acbd41f6
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228841
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=b5ee69f93c36cf11246654c4fca21475d1d8fa76
Submitter: Jenkins
Branch: master

commit b5ee69f93c36cf11246654c4fca21475d1d8fa76
Author: sonu.kumar <email address hidden>
Date: Tue Sep 29 16:27:19 2015 +0530

    Fix order of argument in assertEqual

    Some tests of recordset used incorrect argument
    order in assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed)

    Change-Id: I4eb74da35490e09738411d185af817efd7f4faa2
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229806
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=f42f4b626fdfdedcd9ed719bb206c09cbae8818d
Submitter: Jenkins
Branch: master

commit f42f4b626fdfdedcd9ed719bb206c09cbae8818d
Author: sonu.kumar <email address hidden>
Date: Mon Oct 5 09:39:20 2015 +0530

    Fix order of arguments in assertEqual

    Some tests in test_base.py used incorrect arguments
    order in assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed) as specified in
    the example of http://nullege.com/codes/search/
    testtools.TestCase.assertEquals.

    Partial-Bug: #1259292

    Change-Id: I84128994a9f168fab13f464cd23882d55658456f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235796

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/239400

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bertrand Lallau (<email address hidden>) on branch: master
Review: https://review.openstack.org/239400

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239356
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=6b97b9a7cd5831de84ac618fd843403bb8ad1479
Submitter: Jenkins
Branch: master

commit 6b97b9a7cd5831de84ac618fd843403bb8ad1479
Author: Bertrand Lallau <email address hidden>
Date: Mon Oct 26 08:15:16 2015 +0100

    Fix argument order in assertEqual to (expect, obs)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particular order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit Tests
    fail. There are several Unit Test files where the arguments for assertEqual
    have been swapped.

    Closes-Bug: #1259292
    Change-Id: I17930c8ba8168baba9baddbdb7a54d54497f6a6d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228365
Committed: https://git.openstack.org/cgit/openstack/python-designateclient/commit/?id=6d9a45bf16ecec3944984f6218b822c55f5e4862
Submitter: Jenkins
Branch: master

commit 6d9a45bf16ecec3944984f6218b822c55f5e4862
Author: sonu.kumar <email address hidden>
Date: Tue Oct 13 13:20:36 2015 +0530

    Fixes order of argument in assertEqual

    Some tests in designateclient used incorrect
    argument order in assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Partial-Bug: #1259292

    Change-Id: Icc53b2f21e557170a61ceb52cd6f04c31e3b8425

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235796
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=6a299928336b147ebc9bfb49667709182d0c598c
Submitter: Jenkins
Branch: master

commit 6a299928336b147ebc9bfb49667709182d0c598c
Author: sonu.kumar <email address hidden>
Date: Fri Oct 16 14:39:21 2015 +0530

    Fix order of argument in assertEqual

    Some tests of central used incorrect argument
    order in assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed)

    Change-Id: I8fb43e687e64e133b23c1321659183a8b18c11f6
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239400
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=63d1b2a59048314ebb1a0dadf7a4801f8d1af593
Submitter: Jenkins
Branch: master

commit 63d1b2a59048314ebb1a0dadf7a4801f8d1af593
Author: Bertrand Lallau <email address hidden>
Date: Mon Oct 26 11:50:24 2015 +0100

    Fix argument order in assertEqual to (expect, obs)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particular order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit Tests
    fail. There are several Unit Test files where the arguments for assertEqual
    have been swapped.

    Change-Id: I6fdedcde67f76883257d35d1b812ab8a0e3e0733
    Related-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238240
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=01a3190d44085b5e5663273651fb4afc56b96ade
Submitter: Jenkins
Branch: master

commit 01a3190d44085b5e5663273651fb4afc56b96ade
Author: Nate Potter <email address hidden>
Date: Wed Oct 21 19:07:16 2015 +0000

    Correct assertDictMatch argument order

    Patch to fix the order of the arguments in assertDictMatch to
    (expected, observed) in instances where it was in the
    wrong order.

    Closes-Bug: #1259292

    Change-Id: I969d780ea06190ba5362106ee2b8efa1ee43927c

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/glance 12.0.0.0b1 development milestone.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/264006

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264029
Committed: https://git.openstack.org/cgit/openstack/python-solumclient/commit/?id=6559731fb33bddccb364ab8430f6b41b1447f76f
Submitter: Jenkins
Branch: master

commit 6559731fb33bddccb364ab8430f6b41b1447f76f
Author: reedip <email address hidden>
Date: Wed Jan 6 14:38:55 2016 +0900

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be (expected, observed).
    If a particluar order is kept as a convention, then it helps to provide a cleaner
    message to the developer if Unit Tests fail.
    The following patch fixes this issue

    TrivialFix

    Change-Id: I164dd6b2b820e4ca26bf3406f591ca786893f279
    Closes-Bug: #1259292
    Closes-Bug: #1277104

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-solumclient 2.0.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-cloudkittyclient 0.5.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/219267
Reason: This patch has been idle for a long time, so I am abandoning it to keep the review clean sane. If you're interested in still working on this patch, then please unabandon it and upload a new patchiest.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/219266
Reason: This patch has been idle for a long time, so I am abandoning it to keep the review clean sane. If you're interested in still working on this patch, then please unabandon it and upload a new patchset.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/219265
Reason: This patch has been idle for a long time, so I am abandoning it to keep the review clean sane. If you're interested in still working on this patch, then please unabandon it and upload a new patchset.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264006
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=ea2693b9d9aa65af603814c5eb44414839216bd5
Submitter: Jenkins
Branch: master

commit ea2693b9d9aa65af603814c5eb44414839216bd5
Author: reedip <email address hidden>
Date: Wed Jan 6 12:21:52 2016 +0900

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    TrivialFix

    Change-Id: I817a654733e0f3886ca85778a49aa579592f60ff
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329750

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329764

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329787

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329764
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=fd1e846a60c0e73e641b22af2ed07b91b040c6a2
Submitter: Jenkins
Branch: master

commit fd1e846a60c0e73e641b22af2ed07b91b040c6a2
Author: yuyafei <email address hidden>
Date: Wed Jun 15 13:26:44 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    TrivialFix

    Change-Id: I07b78383ef38731140143c91ae3a902bea55eebb
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332729
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=2410ff06afe2161bb92e11ef36d8602fc5599d34
Submitter: Jenkins
Branch: master

commit 2410ff06afe2161bb92e11ef36d8602fc5599d34
Author: liangjingtao <email address hidden>
Date: Wed Jun 22 18:35:21 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    Change-Id: I85628a1d60fa809f80d658ed7d66dbd5d7e03010
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/333133

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/333144

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329787
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=c3de38ed530b8db77185e819af65574e35ebe134
Submitter: Jenkins
Branch: master

commit c3de38ed530b8db77185e819af65574e35ebe134
Author: zhengyao1 <email address hidden>
Date: Wed Jun 15 16:42:42 2016 +0800

    Use correct order of arguments to assertEqual

    The correct order of arguments to assertEqual that is expected by
    testtools is (expected, observed).

    This patch fixes the inverted usage of arguments in some places
    that have cropped up since the last fix of this bug.

    Change-Id: If8c0dcb58496bc2fcf4c635f384522a1f7d2b2af
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333133
Committed: https://git.openstack.org/cgit/openstack/astara/commit/?id=3fbbcd941c71f6914f7add5157c8f3766afc2450
Submitter: Jenkins
Branch: master

commit 3fbbcd941c71f6914f7add5157c8f3766afc2450
Author: Ji-Wei <email address hidden>
Date: Thu Jun 23 16:12:40 2016 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    This patch will fix the issue.

    Change-Id: I44c7c6a6bf248b17c4f001586a79a91ff9d9dc3d
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/337121

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/337577

[qinchunhua (qin-chunhua)]

I and wen have done this work：）

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338001

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338627

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338646

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338717

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/339033

[Anthony Washington (anthony-washington)]

Tempest fixed proposed.

https://review.openstack.org/339033

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337121
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=a6cab46360df20d9f1d80bc771f07bba39e9c547
Submitter: Jenkins
Branch: master

commit a6cab46360df20d9f1d80bc771f07bba39e9c547
Author: SongmingYan <email address hidden>
Date: Mon Jul 4 06:27:39 2016 -0400

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Closes bug: #1259292

    Change-Id: Ibbb084c4e9c9de8c20dc097730af5e3fdd07a6b9

[OpenStack Infra (hudson-openstack)]

Change abandoned by Anthony Washington (<email address hidden>) on branch: master
Review: https://review.openstack.org/339033

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338001
Committed: https://git.openstack.org/cgit/openstack/solum/commit/?id=adc1b9ddcc77d7f8bc1c05c830f7b0c4a0805b8a
Submitter: Jenkins
Branch: master

commit adc1b9ddcc77d7f8bc1c05c830f7b0c4a0805b8a
Author: yuyafei <email address hidden>
Date: Wed Jul 6 15:32:06 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    TrivialFix
    Closes-Bug: #1259292

    Change-Id: I608b07f857d9fa2d401cab35fff6bdf2defa6d55

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/340654

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329750
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=a177ec0451ed64836694ba51adca06fe38d85e72
Submitter: Jenkins
Branch: master

commit a177ec0451ed64836694ba51adca06fe38d85e72
Author: yuyafei <email address hidden>
Date: Wed Jun 15 12:00:04 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    TrivialFix

    Change-Id: Ib0c04bbb7054776e8f32bb834252198c29232e74
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/340654
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=3438c2b8ad67543638713dec1d307e558ce57980
Submitter: Jenkins
Branch: master

commit 3438c2b8ad67543638713dec1d307e558ce57980
Author: weiweigu <email address hidden>
Date: Tue Jul 12 12:27:32 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    TrivialFix
    Closes-Bug: #1259292

    Change-Id: I03c414a763b2d51210aaec362405912f29850e36

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/330665
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=0f337cb4616fed296c64c5a502614f5192f14225
Submitter: Jenkins
Branch: master

commit 0f337cb4616fed296c64c5a502614f5192f14225
Author: Kanagaraj Manickam <email address hidden>
Date: Thu Jun 16 19:01:02 2016 +0530

    Correct the reference and actual parameters in assertEqual

    AssertEqual always takes the reference object first param
    then actual object as second param, so it corrects
    some unit test cases, where postion is not take care properly.

    Co-Authored-By: <email address hidden>
    Co-Authored-By: <email address hidden>

    Change-Id: I0d98d28891b19520bd16070e10baa9f6cd07aee0
    Partial-Bug: #1259292

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/networking-midonet 1.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338627
Committed: https://git.openstack.org/cgit/openstack/networking-infoblox/commit/?id=a52b6364fa5d812f512837282b884ce7995bd54b
Submitter: Jenkins
Branch: master

commit a52b6364fa5d812f512837282b884ce7995bd54b
Author: hongzhezheng <email address hidden>
Date: Wed Jul 6 20:10:42 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    Change-Id: I197f2d781317b0f0f4b9dce1cd6a438a9b6a7622
    Partial-Bug: #1259292

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/keystone 10.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338646
Committed: https://git.openstack.org/cgit/openstack/networking-l2gw/commit/?id=f9f03505777add4ba0525d6f033b36088820c9ce
Submitter: Jenkins
Branch: master

commit f9f03505777add4ba0525d6f033b36088820c9ce
Author: qinchunhua <email address hidden>
Date: Wed Jul 6 22:04:13 2016 -0400

    Fix the order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Co-Authored-By: <email address hidden>

    Change-Id: I29020058671348e0734906a71ac3ae0798172a23
    Partial-Bug: #1259292

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/python-glanceclient 2.2.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/219269
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/219270
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/glance_store 0.14.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337577
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=6dd7daa0d5579365fc6894f3893120fa9022d8fb
Submitter: Jenkins
Branch: master

commit 6dd7daa0d5579365fc6894f3893120fa9022d8fb
Author: SongmingYan <email address hidden>
Date: Tue Jul 5 05:28:29 2016 -0400

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools
    is assertEqual(expected, observed).

    Closes bug: #1259292

    Change-Id: Ic16cbbe2854311dcad755402363e2f72deea186e

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/os-brick 1.5.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/355722

[Nell Jerram (neil-jerram)]

I'm uncertain about the reasoning behind this bug. I'm afraid I haven't read all 248 comments above (!), but at #7 Steve Baker says "Look at the message that testtools builds for assertEquals fails."

But in a networking-calico test, if I force a failure, I see:

AssertionError: {'/calico/v1/config/EndpointReportingEnabled': True, '/calico/v1/policy/profile/ [truncated]... != {'/scalico/v1/config/InterfacePrefix': 'tap', '/calico/v1/policy/profile/opensta [truncated]...
  {'/calico/v1/Ready': True,
   '/calico/v1/config/EndpointReportingEnabled': True,
- '/calico/v1/config/InterfacePrefix': 'tap',
- '/calico/v1/policy/profile/openstack-sg-SGID-default/rules': {u'inbound_rules': [{u'dst_ports': [u'1:65535'],
? - - -

+ '/calico/v1/policy/profile/openstack-sg-SGID-default/rules': {'inbound_rules': [{'dst_ports': ['1:65535'],
- u'ip_version': 4,
...

And I don't see anything in that message that indicates which is the actual value and which is the expected.

So would appreciate if someone can clarify what is the justification for this bug.

Thanks - Neil

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/355722
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ac404c4bcf978517c33aab3e6c593c59f3ac6c83
Submitter: Jenkins
Branch: master

commit ac404c4bcf978517c33aab3e6c593c59f3ac6c83
Author: Luong Anh Tuan <email address hidden>
Date: Tue Aug 16 12:02:45 2016 +0700

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I83b7009f9b32f4abc88c23cafbe293b65dc25fb4
    Partial-Bug: #1259292

[Sharat Sharma (sharat-sharma)]

https://review.openstack.org/#/c/356483/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/357251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/357251
Committed: https://git.openstack.org/cgit/openstack/bandit/commit/?id=5163b7561bff167ca27cb3c301e403510fea4885
Submitter: Jenkins
Branch: master

commit 5163b7561bff167ca27cb3c301e403510fea4885
Author: liujiong <email address hidden>
Date: Thu Aug 18 22:18:33 2016 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: I582fc1d4080456a85a635c477046876d1d2f4363
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/357664

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/357664
Committed: https://git.openstack.org/cgit/openstack/sahara-tests/commit/?id=e163f7925974ce7a74e29cbf83db7fb00103e470
Submitter: Jenkins
Branch: master

commit 87bae8585033bf371a936d2de330a89d791244ad
Author: Matthew Treinish <email address hidden>
Date: Tue Jun 28 11:53:22 2016 -0400

    Remove unecessary decorators from private interface

    This commit removes the usage of the services decorators from the
    tempest plugin tests. That decorator is an internal interface and
    not meant for external consumption, and is now causing failures
    because of recent tempest changes. Plugins should only use documented
    stable interfaces. [1]

    Also the use of the decorator here actually adds nothing to the tests.
    They do 2 things, add a test attr to filter by service and add a skip
    check on the service availability. However both of these are already
    done, data_processing is already part of the test_id so filtering
    will just work and the skip check for sahara is baked into the base
    test class. So using this decorator does nothing except break the
    plugin.

    [1] http://docs.openstack.org/developer/tempest/plugin.html#stable-tempest-apis-plugins-may-use

    Change-Id: I45587d065c1b7b7f28feb29e8845f8f0f8405b8c

commit f4db8224967267e91abb05dd9c526318589f383b
Author: ZhiQiang Fan <email address hidden>
Date: Mon Apr 18 22:00:47 2016 +0800

    update options mentioned in tempest readme

    Some options have already been deprecated but still used in tempest
    README.rst, let's use the new one.

    Change-Id: Ic3bfb66b0898869149126c21aef0b2fd673385e2

commit f82c7db143bb7bf3c358e735f9646a17684ba5b6
Author: Luigi Toscano <email address hidden>
Date: Fri Feb 26 11:24:32 2016 +0100

    Use the integrated tempest.lib module

    Tempest-lib has been reintegrated into tempest (as code, but it still provides
    a stable API). The old library is still available, but tempest tests are
    failing because when sahara is installed and exports the scenario tests
    for python clients, python-lib is not installed (it's correcly in
    test-requirements.txt, not requirements.txt), and tempest does not
    install tempest-lib anymore. Hence, fix the tests to use the new
    official location.

    Change-Id: Iaded03ee387b4a0bbabb7bfe9e54d38e010d9c4f

commit 85ce728189d8f8a63843ebde5950a0c56233fa3a
Author: luhuichun <email address hidden>
Date: Tue Dec 1 14:09:22 2015 +0800

    Replacing all hard coded cluster status using cluster_utils

    Change-Id: I9550e98553da9f7bfc57923e44a789e07a912ff4
    Closes-bug: 1517061

commit 0abdc18a94089bf698582daa051a96fd645935f3
Author: Evgeny Sikachev <email address hidden>
Date: Thu Nov 26 13:40:51 2015 +0300

    Add missed checks for testing update method

    In tempest tests for saharaclient we have missed methods
    for checking update of templates.
    Closes-bug: #1520140

    Change-Id: I8191e3344ecffd7a2ed442ba3d561741701c45e2

commit 80bfb9a469d2a289e903b19488214855b8a7fa94
Author: Evgeny Sikachev <email address hidden>
Date: Tue Nov 17 16:05:04 2015 +0300

    Adding t...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/361025

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333144
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=80c631fc011924112a566ae5ca6648ce2532f1ae
Submitter: Jenkins
Branch: master

commit 80c631fc011924112a566ae5ca6648ce2532f1ae
Author: Ji-Wei <email address hidden>
Date: Thu Jun 23 16:42:45 2016 +0800

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).
    This patch fix the issue.

    Change-Id: I02ab9095188258d7b14ccd644422b55c162c92f0
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-barbicanclient 4.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/solum 5.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-sfc 2.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/367442

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-sfc 2.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/361025
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=f7d95a4045c3407063f7906eeb3dda3f4ac1b58c
Submitter: Jenkins
Branch: master

commit f7d95a4045c3407063f7906eeb3dda3f4ac1b58c
Author: SongmingYan <email address hidden>
Date: Fri Aug 26 04:42:38 2016 -0400

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools
    is assertEqual(expected, observed).

    Closes bug: #1259292

    Change-Id: If670c54ee7f6dae2911c1165619dcad4dca6c06d

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tuan Luong-Anh (<email address hidden>) on branch: master
Review: https://review.openstack.org/356283

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338179
Committed: https://git.openstack.org/cgit/openstack/networking-calico/commit/?id=8599fe0af907bc5aeff29c994bafdf87ef558b71
Submitter: Jenkins
Branch: master

commit 8599fe0af907bc5aeff29c994bafdf87ef558b71
Author: SongmingYan <email address hidden>
Date: Wed Jul 6 06:48:10 2016 -0400

    Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

    Closes bug: #1259292

    Change-Id: I39aa28bea07a3cc6dcab472d526b7d3436d5270d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 1.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/378699
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=403e440f8504d2716b154043565032e3d145b63e
Submitter: Jenkins
Branch: master

commit 403e440f8504d2716b154043565032e3d145b63e
Author: Jiong Liu <email address hidden>
Date: Wed Sep 28 23:19:16 2016 +0800

    Fix order of arguments in assertEqual

    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: I93eaab96f170e72cfcbc763f384fd9358842ef69
    Partial-Bug: #1259292

[Steve Martinelli (stevemar)]

Fixed in pycadf: https://review.openstack.org/#/c/338781/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338717
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=86d91e4e4e39ed0b4b65e393ca49172fd555ddd0
Submitter: Jenkins
Branch: master

commit 86d91e4e4e39ed0b4b65e393ca49172fd555ddd0
Author: hongzhezheng <email address hidden>
Date: Thu Jul 7 16:23:31 2016 +0800

    Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

    Change-Id: I5209e5889cfe62c66dc675c00e3ccaf22410f637
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/378684
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=bd97bedb3f9b0bddcf3556acc4cd01ab35c7e960
Submitter: Jenkins
Branch: master

commit bd97bedb3f9b0bddcf3556acc4cd01ab35c7e960
Author: Jiong Liu <email address hidden>
Date: Wed Sep 28 22:59:54 2016 +0800

    Fix order of arguments in assertEqual

    The correct order expected by testtools is assertEqual(expected, observed).

    Change-Id: I8457af6e15a9000dd6c54ad8199331e75bd3c7fd
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 1.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344085
Committed: https://git.openstack.org/cgit/openstack/networking-l2gw/commit/?id=0ded69ae72c8395a1324505e516288801ba369ab
Submitter: Jenkins
Branch: master

commit 0ded69ae72c8395a1324505e516288801ba369ab
Author: LiuYong <email address hidden>
Date: Wed Jul 20 00:05:29 2016 +0800

    Remove execute permission which is added by mistake in l2gw

    Some files in networking-l2gw/tests/unit
    were given execute permission by mistake
    in Change-Id: I29020058671348e0734906a71ac3ae0798172a23.
    This proposal want to remove the error permission.

    Change-Id: I7e6466f8e9a0886e293df3f229d03a49b6fc92cc
    Related-Id: I29020058671348e0734906a71ac3ae0798172a23
    Partial-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cloudkittyclient 0.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-barbicanclient 4.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-sfc 3.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-barbicanclient 4.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/356483

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack-dev/pbr 2.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/443698

[OpenStack Infra (hudson-openstack)]

Change abandoned by sudhir agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/443698

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/444582

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/450148

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/450148

[OpenStack Infra (hudson-openstack)]

Change abandoned by sudhir agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/444582

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444582
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=0aec3cc166590ea4bc95d4a0dacd7f79dfa84735
Submitter: Jenkins
Branch: master

commit 0aec3cc166590ea4bc95d4a0dacd7f79dfa84735
Author: sudhir_agarwal <email address hidden>
Date: Fri Jun 30 16:43:39 2017 +0530

    Fixed order of arguments in assertEqual

    Some tests used incorrect order of arguments in
    assertEqual(observed, expected). The correct order expected
    by testtool is assertEqual(expected, observed).

    Partial-Bug: #1259292

    Change-Id: I944b72f743a21d0908d17485c25aeb0e7ee70cba

[OpenStack Infra (hudson-openstack)]

Change abandoned by sudhir agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/489232

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/564482

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564482
Committed: https://git.openstack.org/cgit/openstack/freezer-api/commit/?id=67e5953c1c66a27dea021abb86029b2470114fb4
Submitter: Zuul
Branch: master

commit 67e5953c1c66a27dea021abb86029b2470114fb4
Author: Oleksiy Petrenko <email address hidden>
Date: Thu Apr 26 15:29:57 2018 +0300

    Rework AseertEqual params order in freezer-api
    from (got, expected) to (expected, got)

    Change-Id: Id4ec8f561ce707fbbb60ae49bf5ad95d22ecd223
    Close-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/485050
Committed: https://git.openstack.org/cgit/openstack/blazar/commit/?id=3fdac0da7dc2ca752b9dd9de854c16e1d8debf1b
Submitter: Zuul
Branch: master

commit 3fdac0da7dc2ca752b9dd9de854c16e1d8debf1b
Author: Kiran_totad <email address hidden>
Date: Wed Jul 19 11:33:48 2017 +0530

    Fix order of arguments in assertEqual

    Some tests incorrectly used the order assertEqual(observed, expected).

    The correct order expected by testtools is
    assertEqual(expected, observed).

    Change-Id: Idbb127147df5acc03287b6a7c1f8d24a37fd663e
    Closes-Bug: #1259292

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/blazar 3.0.0.0rc1 release candidate.