FWaaS v1 policy_rules: add_router/remove_rule actions should refer update_firewall policy

Bug #1703952 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Neutron FWaaS dashboard
Fix Released
Undecided
Akihiro Motoki

Bug Description

The table action AddRouterToFirewallLink and RemoveRouterFromFirewallLink refers the policies like:

    policy_rules = (("neutron-fwaas", "get_firewall"),
                    ("neutron-fwaas", "add_router"),)

"add_router" is not defined in the neutron-fwaas policy JSON file.

In addition, in the REST API, 'add_router' operation is PUT operation, so using 'update_firewall' policy definition looks better.

The same thing can be said for 'remove_router'.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/483135

Changed in neutron-fwaas-dashboard:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas-dashboard (master)

Reviewed: https://review.openstack.org/483135
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=782ce8d86297761205f36ea0960442a33b002990
Submitter: Jenkins
Branch: master

commit 782ce8d86297761205f36ea0960442a33b002990
Author: Akihiro Motoki <email address hidden>
Date: Wed Jul 12 18:45:09 2017 +0000

    Use update_firewall policy for add/remove router operation

    In the REST API, add/remove_router operations are PUT operation,
    so using 'update_firewall' policy definition looks better.

    Closes-Bug: #1703952
    Change-Id: I0cf600c4c3e1b8a1a0f4c0e3b29e8569f26f065c

Changed in neutron-fwaas-dashboard:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.