ovsvapp-agent constraint violation error

[Stephen Ma]

This error is found in the ovsvapp-agent log:

2019-04-02 16:54:52.761 18743 ERROR networking_vsphere.agent.ovsvapp_agent [-] Unable to set openflow version: Exit code: 1; Stdin: ; Stdout: ; Stderr: ovs-vsctl: constraint violation: "'OpenFlow10'" is not one of the allowed values (["OpenFlow10", "OpenFlow11", "OpenFlow12", "OpenFlow13", "OpenFlow14", "OpenFlow15", "OpenFlow16"])
: ProcessExecutionError: Exit code: 1; Stdin: ; Stdout: ; Stderr: ovs-vsctl: constraint violation: "'OpenFlow10'" is not one of the allowed values (["OpenFlow10", "OpenFlow11", "OpenFlow12", "OpenFlow13", "OpenFlow14", "OpenFlow15", "OpenFlow16"])
2019-04-02 16:54:52.762 18743 DEBUG neutron.agent.linux.utils [-] Running command (rootwrap daemon): ['ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=ofport', 'list', 'Interface', 'patch-tun'] execute_rootwrap_daemon /opt/stack/venv/neutron-20190329T074525Z/lib/python2.7/site-packages/neutron/agent/linux/utils.py:103
2019-04-02 16:54:52.777 18743 DEBUG neutron.agent.linux.utils [-] Running command (rootwrap daemon): ['ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=ofport', 'l

This is ran in with neutron stable/rocky.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649415
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=433bff80d6a15c1e7f5aba6a7f00a357ade839ca
Submitter: Zuul
Branch: master

commit 433bff80d6a15c1e7f5aba6a7f00a357ade839ca
Author: Stephen Ma <email address hidden>
Date: Tue Apr 2 10:50:21 2019 -0700

    Fix the method call error in set_openflow_version

    In set_openflow_version, the add_protocols call is incorrect.
    Currently it is calling the function with only 1 argument
    (a list of supported OpenFlow versions). The function
    actually expects multiple arguments where each one is a
    supported OpenFlow version. See [1].

    [1] https://git.openstack.org/cgit/openstack/neutron/tree/neutron/agent/common/ovs_lib.py#n258

    Closes-bug: #1822861
    Change-Id: I3188235d46687aed7b059b1176dd6abf05b994cf

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/649482

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649482
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=8de4db3bb0bbd513cb3fb504e759f58e547fc994
Submitter: Zuul
Branch: stable/rocky

commit 8de4db3bb0bbd513cb3fb504e759f58e547fc994
Author: Stephen Ma <email address hidden>
Date: Tue Apr 2 10:50:21 2019 -0700

    Fix the method call error in set_openflow_version

    In set_openflow_version, the add_protocols call is incorrect.
    Currently it is calling the function with only 1 argument
    (a list of supported OpenFlow versions). The function
    actually expects multiple arguments where each one is a
    supported OpenFlow version. See [1].

    [1] https://git.openstack.org/cgit/openstack/neutron/tree/neutron/agent/common/ovs_lib.py#n258

    Closes-bug: #1822861
    Change-Id: I3188235d46687aed7b059b1176dd6abf05b994cf
    (cherry picked from commit 433bff80d6a15c1e7f5aba6a7f00a357ade839ca)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/650084

[OpenStack Infra (hudson-openstack)]

Change abandoned by stephen-ma (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/650084
Reason: Patch not needed. The reason is that neutron's ovs_lib still has set_protocols method available.