vxlan-gpe: agent fails to delete lisp remote eid mapping

[Onong Tayeng]

Spawn two VMs on two different compute nodes
Make sure the remote eid mappings are created in VPP
Restart ML2 agent on one of the compute nodes
Delete the VM running on the node where ML2 agent was restarted
The other VM's remote eid mapping is not cleaned up in VPP and the following shows up in the logs:

2020-08-25 10:04:35.088 40353 INFO networking_vpp.utils.file_monitor [-] File c036944a-1b99-4f53-9ff0-3852f7747493 removed from tracked file index
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils [-] delete key /networking-vpp/nodes/cmp001/ports/c036944a-1b99-4f53-9ff0-3852f7747493 value None couldnot be processed: AttributeError: 'MACAddress' object has no attribute 'split'
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils Traceback (most recent call last):
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/etcdutils.py", line 630, in do_watch
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils self.do_work(rv.action, rv.key, rv.value)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/etcdutils.py", line 717, in do_work
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils self.key_change(action, key, value)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/etcdutils.py", line 742, in key_change
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils self.removed(short_key)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 3238, in removed
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils self.data.unbind(port)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 2528, in unbind
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils self.vppf.unbind_interface_on_host(id)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 993, in unbind_interface_on_host
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils net['segmentation_id'])
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/network_interface.py", line 296, in delete_network
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils driver.remove_network_from_vpp(net)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/network_interface.py", line 170, in remove_network_from_vpp
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils self.vppf.gpe.clear_remote_gpe_mappings(segmentation_id)
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/gpe.py", line 147, in clear_remote_gpe_mappings
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils if len(mac.split(':')) == 6 and segmentation_id == vni:
2020-08-25 10:04:37.195 40353 ERROR networking_vpp.etcdutils AttributeError: 'MACAddress' object has no attribute 'split'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/747913

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747913
Committed: https://git.openstack.org/cgit/x/networking-vpp/commit/?id=5d4f0ab541c5d6d3e88660faaf2c5f9fb1c7df5d
Submitter: Zuul
Branch: master

commit 5d4f0ab541c5d6d3e88660faaf2c5f9fb1c7df5d
Author: Onong Tayeng <email address hidden>
Date: Tue Aug 25 17:44:56 2020 +0530

    vxlan-gpe: fix failure to delete lisp remote eid mapping

    When agent is restarted, it re-creates its in-memory remote eid
    mappings by querying VPP which results in the mac field containing
    the new PAPI MACAddress object instead of string. This causes the
    failure.

    Change-Id: I303cdf3e51a2fc38c5cddfb03643ba6493503846
    CLoses-Bug: #1892862