vxlan-gpe: lisp arp entry cleanup fails

[Onong Tayeng]

During deletion of a VM, the L2 arp entry cleanup fails.

Here's the backtrace:

2020-08-21 16:21:07.561 19467 INFO networking_vpp.utils.file_monitor [-] File b0151d69-b0da-4489-b098-59a6bf3be4d0 removed from tracked file index
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils [-] delete key /networking-vpp/nodes/cmp001/ports/b0151d69-b0da-4489-b098-59a6bf3be4d0 value None couldnot be
processed: AttributeError: 'MACAddress' object has no attribute 'replace'
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils Traceback (most recent call last):
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/etcdutils.py", line 630, in do_watch
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.do_work(rv.action, rv.key, rv.value)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/etcdutils.py", line 717, in do_work
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.key_change(action, key, value)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/etcdutils.py", line 742, in key_change
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.removed(short_key)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 3235, in removed
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.data.unbind(port)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 2525, in unbind
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.vppf.unbind_interface_on_host(id)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 990, in unbind_interface_on_host
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils net['segmentation_id'])
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/network_interface.py", line 296, in delete_network
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils driver.remove_network_from_vpp(net)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/network_interface.py", line 170, in remove_network_from_vpp
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.vppf.gpe.clear_remote_gpe_mappings(segmentation_id)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/gpe.py", line 151, in clear_remote_gpe_mappings
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils self.vpp.clear_lisp_arp_entries(bridge_domain)
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/vpp.py", line 1533, in clear_lisp_arp_entries
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils arp_entry = {"mac": mac_to_bytes(mac), "ip4": ip4}
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/vpp.py", line 44, in mac_to_bytes
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils return bytes.fromhex(mac.replace(':', ''))
2020-08-21 16:21:10.314 19467 ERROR networking_vpp.etcdutils AttributeError: 'MACAddress' object has no attribute 'replace'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/747707

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747707
Committed: https://git.openstack.org/cgit/x/networking-vpp/commit/?id=53e59cf7868a3ef997bcf493411634d3bcaa99a0
Submitter: Zuul
Branch: master

commit 53e59cf7868a3ef997bcf493411634d3bcaa99a0
Author: Onong Tayeng <email address hidden>
Date: Mon Aug 24 17:56:58 2020 +0530

    vxlan-gpe: fix lisp l2 arp entry cleanup failure

    During deletion of a gpe port, the cleanup of the l2 arp entry fails.
    This happens because PAPI returns the mac address as the new
    MACAddress object whereas ML2 agent assumes it to be a string.

    Change-Id: I46a132fe5aa4b6505bbb3479a9ced2b38df3a46b
    Closes-Bug: #1892700