unnecessary linux bridge errors in log

[Onong Tayeng]

Every now and then, the following error msg and trace clobbers the agent logs:

2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server [-] Can't add interface tap7c5bb1e1-5b to bridge br-7c5bb1e1-5b: Exit code: 255; Stdin: ; Stdout: ; Stderr: Error: t

: neutron_lib.exceptions.ProcessExecutionError: Exit code: 255; Stdin: ; Stdout: ; Stderr: Error: argument "br-7c5bb1e1-5b" is wrong: Device does not exist
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server Traceback (most recent call last):
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server File "/usr/local/lib/python3.6/dist-packages/networking_vpp/agent/server.py", line 747, in ensure_tap_in_bridge
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server bridge.addif(tap_name)
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server File "/usr/lib/python3/dist-packages/neutron/agent/linux/bridge_lib.py", line 84, in addif
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server return self._ip_link(['set', 'dev', interface, 'master', self.name])
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server File "/usr/lib/python3/dist-packages/neutron/agent/linux/bridge_lib.py", line 58, in _ip_link
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server return ip_wrapper.netns.execute(cmd, run_as_root=True)
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server File "/usr/lib/python3/dist-packages/neutron/agent/linux/ip_lib.py", line 794, in execute
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server run_as_root=run_as_root)
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server File "/usr/lib/python3/dist-packages/neutron/agent/linux/utils.py", line 147, in execute
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server returncode=returncode)
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server neutron_lib.exceptions.ProcessExecutionError: Exit code: 255; Stdin: ; Stdout: ; Stderr: Error: argument "br-7c5bb1t
2020-06-19 10:34:02.665 14294 ERROR networking_vpp.agent.server

This happens because the linux bridge has been deleted by the time the tap_notify_thread tries to add the tap interface to it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/736987

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/736987
Committed: https://git.openstack.org/cgit/x/networking-vpp/commit/?id=3284821ec11d9d7952f097817e849c3543ebb4f1
Submitter: Zuul
Branch: master

commit 3284821ec11d9d7952f097817e849c3543ebb4f1
Author: Onong Tayeng <email address hidden>
Date: Fri Jun 19 17:33:59 2020 +0530

    remove non-harmful traceback

    When the linux bridge has been deleted by the time the
    tap_notify_thread tries to add the tap interface to it, it leads to
    unnecessary and non-harmful error traceback in the agent logs. This
    fix makes sure such tracebacks do not clobber the logs.

    Closes-Bug: #1884242
    Change-Id: Ibe1fd4f39aecafa61bf5d777c1d2571e81aaf192