stale remote_groups in etcd

[Onong Tayeng]

The agent does not seem to delete all the associated remote_group entries in etcd after the security group is deleted.

Here's an example:

[root@overcloud-controller-0 neutron]# myetcdctl ls -r | grep -e secgroups -e remote
/networking-vpp/global/secgroups
/networking-vpp/global/secgroups/7ca832ad-3f8e-4554-9f94-96fcc519e2c2
/networking-vpp/global/secgroups/03db28cf-c7fe-403d-9f01-c10eb68376b8
/networking-vpp/global/remote_group
/networking-vpp/global/remote_group/c225611c-b50b-49a8-946d-835562a53ee1
/networking-vpp/global/remote_group/b8e90b8d-ef13-44d7-be03-a0e69b91863f
/networking-vpp/global/remote_group/7ca832ad-3f8e-4554-9f94-96fcc519e2c2
/networking-vpp/global/remote_group/7ca832ad-3f8e-4554-9f94-96fcc519e2c2/b8cb4a6f-793e-4e8a-a38c-e8e9b01d765a
/networking-vpp/global/remote_group/c3ca050d-892b-4121-96a6-3b7c6451b984
/networking-vpp/global/remote_group/0bfe99e4-b3d3-4f63-93f7-d589e4bd7d21
[root@overcloud-controller-0 neutron]#

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550607
Committed: https://git.openstack.org/cgit/openstack/networking-vpp/commit/?id=8552ab06368d0f1bfbee8f697793864d47afcd68
Submitter: Zuul
Branch: master

commit 8552ab06368d0f1bfbee8f697793864d47afcd68
Author: Naveen Joy <email address hidden>
Date: Wed Mar 7 12:56:59 2018 -0800

    Remove stale remote-groups from etcd.

    When a security group is deleted, remove the key from remote-groups
    to avoid any stale etcd keys.

    Closes-Bug: #1719625
    Change-Id: I62f288768c3780db094a772d33f275418c5f959b