make get_port_mask more efficient by avoiding some unnecessarily mask checking

Bug #1599037 reported by ding bo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-sfc
In Progress
Low
ding bo

Bug Description

get_port_mask function is used to aggregate port range into masks to install fewer flows in ovs. But, this function literates all possible masks to check if it is needed. In fact, some iterate can be avoided to make this function better time complexity.

original code here:
https://github.com/openstack/networking-sfc/blob/master/networking_sfc/services/sfc/common/ovs_ext_lib.py#L35

ding bo (longddropt)
Changed in networking-sfc:
assignee: nobody → ding bo (longddropt)
Changed in networking-sfc:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-sfc (master)

Fix proposed to branch: master
Review: https://review.openstack.org/338741

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-sfc (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/338741
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Louis Fourie (lfourie)
Changed in networking-sfc:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.